netdev - Re: [PATCH net-next] tools: ynl: default to --process-unknown in installed mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <m2a55b56e0.fsf@gmail.com>
Date: Fri, 11 Jul 2025 12:11:35 +0100
From: Donald Hunter <donald.hunter@...il.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net,  netdev@...r.kernel.org,  edumazet@...gle.com,
  pabeni@...hat.com,  andrew+netdev@...n.ch,  horms@...nel.org,
  jstancek@...hat.com
Subject: Re: [PATCH net-next] tools: ynl: default to --process-unknown in
 installed mode

Jakub Kicinski <kuba@...nel.org> writes:

> We default to raising an exception when unknown attrs are found
> to make sure those are noticed during development.
> When YNL CLI is "installed" and used by sysadmins erroring out
> is not going to be helpful. It's far more likely the user space
> is older than the kernel in that case, than that some attr is
> misdefined or missing.
>
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Good call.

Reviewed-by: Donald Hunter <donald.hunter@...il.com>

> ---
> CC: donald.hunter@...il.com
> CC: jstancek@...hat.com
> ---
>  tools/net/ynl/pyynl/cli.py | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/tools/net/ynl/pyynl/cli.py b/tools/net/ynl/pyynl/cli.py
> index 33ccc5c1843b..8c192e900bd3 100755
> --- a/tools/net/ynl/pyynl/cli.py
> +++ b/tools/net/ynl/pyynl/cli.py
> @@ -113,6 +113,8 @@ relative_schema_dir='../../../../Documentation/netlink'
>          spec = f"{spec_dir()}/{args.family}.yaml"
>          if args.schema is None and spec.startswith(sys_schema_dir):
>              args.schema = '' # disable schema validation when installed
> +        if args.process_unknown is None:
> +            args.process_unknown = True
>      else:
>          spec = args.spec
>      if not os.path.isfile(spec):