netdev - Re: [PATCH net-next v3 2/8] net: s/dev_get_port_parent_id/netif_get_port_parent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250710175251.5b2004f7@kernel.org>
Date: Thu, 10 Jul 2025 17:52:51 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Stanislav Fomichev <sdf@...ichev.me>
Cc: netdev@...r.kernel.org, davem@...emloft.net, edumazet@...gle.com,
 pabeni@...hat.com
Subject: Re: [PATCH net-next v3 2/8] net:
 s/dev_get_port_parent_id/netif_get_port_parent_id/

On Tue,  8 Jul 2025 14:38:23 -0700 Stanislav Fomichev wrote:
>  /**
> - *	dev_get_port_parent_id - Get the device's port parent identifier
> - *	@dev: network device
> - *	@ppid: pointer to a storage for the port's parent identifier
> - *	@recurse: allow/disallow recursion to lower devices
> + * netif_get_port_parent_id() - Get the device's port parent identifier
> + * @dev: network device
> + * @ppid: pointer to a storage for the port's parent identifier
> + * @recurse: allow/disallow recursion to lower devices
>   *
> - *	Get the devices's port parent identifier
> + * Get the devices's port parent identifier
>   */

At the risk of annoying you I'd suggest adding a Return: statement
while you touch these kdocs. Here are some popular phrasings:

 * Return: 0 on success, or a negative error code on failure
 * Return: 0 on success, -errno on failure.
 * Return: 0 on success, -errno otherwise.