netdev - Re: [PATCH net-next 2/5] selftests: drv-net: Test XDP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250711064146.0db275a7@kernel.org>
Date: Fri, 11 Jul 2025 06:41:46 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Mohsin Bashir <mohsin.bashr@...il.com>
Cc: netdev@...r.kernel.org, andrew+netdev@...n.ch, davem@...emloft.net,
 edumazet@...gle.com, pabeni@...hat.com, shuah@...nel.org, horms@...nel.org,
 cratiu@...dia.com, noren@...dia.com, cjubran@...dia.com, mbloch@...dia.com,
 jdamato@...tly.com, gal@...dia.com, sdf@...ichev.me, ast@...nel.org,
 daniel@...earbox.net, hawk@...nel.org, john.fastabend@...il.com,
 bpf@...r.kernel.org, linux-kselftest@...r.kernel.org
Subject: Re: [PATCH net-next 2/5] selftests: drv-net: Test XDP_PASS/DROP
 support

On Thu, 10 Jul 2025 11:43:48 -0700 Mohsin Bashir wrote:
> +    try:
> +        cmd(
> +        f"ip link set dev {cfg.ifname} mtu {bpf_info.mtu} xdp obj {abs_path} "
> +        f"sec {bpf_info.xdp_sec}",
> +        shell=True
> +        )
> +        defer(ip, f"link set dev {cfg.ifname} mtu 1500 xdp off")
> +    except Exception as e:
> +        raise KsftSkipEx(f"Failed to attach XDP porgram: {bpf_info.name}") from e

Please don't catch the exception here, let it break the test.
The cmd exception carries the info we need to debug, I had
to remove this to see why the test was skipping. We could try
to add the error lines to the SkipEx but frankly I don't think
it's worth the LoC.
-- 
pw-bot: cr