netdev - Re: [PATCH v4 0/3] rust: Build PHY device tables by using module_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20250712.075305.1992034457870738678.fujita.tomonori@gmail.com>
Date: Sat, 12 Jul 2025 07:53:05 +0900 (JST)
From: FUJITA Tomonori <fujita.tomonori@...il.com>
To: dakr@...nel.org
Cc: fujita.tomonori@...il.com, alex.gaynor@...il.com,
 gregkh@...uxfoundation.org, ojeda@...nel.org, rafael@...nel.org,
 robh@...nel.org, saravanak@...gle.com, tmgross@...ch.edu,
 a.hindborg@...nel.org, aliceryhl@...gle.com, bhelgaas@...gle.com,
 bjorn3_gh@...tonmail.com, boqun.feng@...il.com, david.m.ertman@...el.com,
 devicetree@...r.kernel.org, gary@...yguo.net, ira.weiny@...el.com,
 kwilczynski@...nel.org, lenb@...nel.org, leon@...nel.org,
 linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-pci@...r.kernel.org, lossin@...nel.org, netdev@...r.kernel.org,
 rust-for-linux@...r.kernel.org
Subject: Re: [PATCH v4 0/3] rust: Build PHY device tables by using
 module_device_table macro

On Sat, 12 Jul 2025 00:19:54 +0200
Danilo Krummrich <dakr@...nel.org> wrote:

> On 7/11/25 6:09 AM, FUJITA Tomonori wrote:
>> Build PHY device tables by using module_device_table macro.
>> The PHY abstractions have been generating their own device tables
>> manually instead of using the module_device_table macro provided by
>> the device_id crate. However, the format of device tables occasionally
>> changes [1] [2], requiring updates to both the device_id crate and the
>> custom
>> format used by the PHY abstractions, which is cumbersome to maintain.
>> [1]:
>> https://lore.kernel.org/lkml/20241119235705.1576946-14-masahiroy@kernel.org/
>> [2]:
>> https://lore.kernel.org/lkml/6e2f70b07a710e761eb68d089d96cee7b27bb2d5.1750511018.git.legion@kernel.org/
>> Danilo, I incorporated your fixes into the first patch and mentioned
>> them in the commit message. Let me know if you'd rather take a
>> different approach.
> 
> Thanks FUJITA -- no need to mention it though. :)
> 
> Did you forget to pick up Jakub's ACK or was this intentional?

Oops, please add his ACK when applying.


Thanks,