netdev - Re: [PATCH v2 net-next] dev: Pass netdevice_tracker to dev_get_by_flags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250712102702.GW721198@horms.kernel.org>
Date: Sat, 12 Jul 2025 11:27:02 +0100
From: Simon Horman <horms@...nel.org>
To: Kuniyuki Iwashima <kuniyu@...gle.com>
Cc: "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Andrew Lunn <andrew+netdev@...n.ch>,
	David Ahern <dsahern@...nel.org>,
	Kuniyuki Iwashima <kuni1840@...il.com>, netdev@...r.kernel.org
Subject: Re: [PATCH v2 net-next] dev: Pass netdevice_tracker to
 dev_get_by_flags_rcu().

On Fri, Jul 11, 2025 at 05:10:59AM +0000, Kuniyuki Iwashima wrote:
> This is a follow-up for commit eb1ac9ff6c4a5 ("ipv6: anycast: Don't
> hold RTNL for IPV6_JOIN_ANYCAST.").
> 
> We should not add a new device lookup API without netdevice_tracker.
> 
> Let's pass netdevice_tracker to dev_get_by_flags_rcu() and rename it
> with netdev_ prefix to match other newer APIs.
> 
> Note that we always use GFP_ATOMIC for netdev_hold() as it's expected
> to be called under RCU.
> 
> Suggested-by: Jakub Kicinski <kuba@...nel.org>
> Link: https://lore.kernel.org/netdev/20250708184053.102109f6@kernel.org/
> Signed-off-by: Kuniyuki Iwashima <kuniyu@...gle.com>
> ---
> v2:
>   * Use netdev_tracker for other places ipv6_sock_ac_join()
>   * Fix func name for EXPORT_IPV6_MOD()
>   * Update kdoc
> 
> v1: https://lore.kernel.org/netdev/20250709190144.659194-1-kuniyu@google.com/

Reviewed-by: Simon Horman <horms@...nel.org>