netdev - Re: [PATCH v1 net] rpl: Fix use-after-free in rpl_do_srh

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250712141016.GC721198@horms.kernel.org>
Date: Sat, 12 Jul 2025 15:10:16 +0100
From: Simon Horman <horms@...nel.org>
To: Kuniyuki Iwashima <kuniyu@...gle.com>
Cc: "David S. Miller" <davem@...emloft.net>,
	David Ahern <dsahern@...nel.org>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Alexander Aring <alex.aring@...il.com>,
	Kuniyuki Iwashima <kuni1840@...il.com>, netdev@...r.kernel.org
Subject: Re: [PATCH v1 net] rpl: Fix use-after-free in rpl_do_srh_inline().

On Fri, Jul 11, 2025 at 06:21:19PM +0000, Kuniyuki Iwashima wrote:
> Running lwt_dst_cache_ref_loop.sh in selftest with KASAN triggers
> the splat below [0].
> 
> rpl_do_srh_inline() fetches ipv6_hdr(skb) and accesses it after
> skb_cow_head(), which is illegal as the header could be freed then.
> 
> Let's fix it by making oldhdr to a local struct instead of a pointer.

...

> Fixes: a7a29f9c361f8 ("net: ipv6: add rpl sr tunnel")
> Signed-off-by: Kuniyuki Iwashima <kuniyu@...gle.com>

Reviewed-by: Simon Horman <horms@...nel.org>