netdev - Re: [PATCH net 2/3] ovpn: explicitly reject netlink attr PEER_LOCAL_PORT in CMD_PEER

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5bb491d4-11ff-4c63-96c4-de83074e6ae4@openvpn.net>
Date: Sun, 13 Jul 2025 22:04:49 +0200
From: Antonio Quartulli <antonio@...nvpn.net>
To: Jakub Kicinski <kuba@...nel.org>, Sabrina Dubroca <sd@...asysnail.net>
Cc: Donald Hunter <donald.hunter@...il.com>, netdev@...r.kernel.org,
 "David S . Miller" <davem@...emloft.net>, Eric Dumazet
 <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
 Ralf Lici <ralf@...delbit.com>
Subject: Re: [PATCH net 2/3] ovpn: explicitly reject netlink attr
 PEER_LOCAL_PORT in CMD_PEER_NEW/SET

Hi Jakub,

I was on vacation last week and I am processing your emails now..

On 08/07/2025 16:47, Jakub Kicinski wrote:
> In any case. I think what I suggested is slightly better than
> opencoding, even if verbose :) So I set the patches to Changes
> Requested..

So you'd want to go with what you suggested on July 7th?
I.e. using subset-of and defining 'peer-input'/'ovpn-peer-input'.
Did I get it right?

As Sabrina pointed out, I'll also define a subset for PEER_DEL/GET, 
where we only need the PEER_ID.

Regards,

-- 
Antonio Quartulli
OpenVPN Inc.