netdev - [Patch v3 net 0/4] netem: Fix skb duplication logic and prevent infinite loops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20250713214748.1377876-1-xiyou.wangcong@gmail.com>
Date: Sun, 13 Jul 2025 14:47:44 -0700
From: Cong Wang <xiyou.wangcong@...il.com>
To: netdev@...r.kernel.org
Cc: jhs@...atatu.com,
	will@...lsroot.io,
	stephen@...workplumber.org,
	Cong Wang <xiyou.wangcong@...il.com>
Subject: [Patch v3 net 0/4] netem: Fix skb duplication logic and prevent infinite loops

This patchset fixes the infinite loops due to duplication in netem, the
real root cause of this problem is enqueuing to the root qdisc, which is
now changed to enqueuing to the same qdisc. This is more reasonable,
more predictable from users' perspective, and more elegant.

Please see more details in patch 1/4 which contains two pages of
detailed explanation including why it is safe and better.

This replaces the patches from William, with much less code and without
any workaround. More importantly, this does not break any use case at
all.

---
v3: Fixed the root cause of enqueuing to root
    Switched back to netem_skb_cb safely
    Added two more test cases

v2: Fixed a typo
    Improved tdc selftest to check sent bytes

Cong Wang (4):
  net_sched: Implement the right netem duplication behavior
  selftests/tc-testing: Add a nested netem duplicate test
  selftests/tc-testing: Add a test case for piro with netem duplicate
  selftests/tc-testing: Add a test case for mq with netem duplicate

 net/sched/sch_netem.c                         | 26 ++++----
 .../tc-testing/tc-tests/infra/qdiscs.json     | 59 +++++++++++++++++++
 .../tc-testing/tc-tests/qdiscs/netem.json     | 25 ++++++++
 3 files changed, 99 insertions(+), 11 deletions(-)

-- 
2.34.1