netdev - Re: [PATCH net v3 2/3] net: phy: allow drivers to disable polling via get_next_update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aHTTtHsYDP3YXgmF@pengutronix.de>
Date: Mon, 14 Jul 2025 11:53:56 +0200
From: Oleksij Rempel <o.rempel@...gutronix.de>
To: Simon Horman <horms@...nel.org>
Cc: Andrew Lunn <andrew@...n.ch>, Heiner Kallweit <hkallweit1@...il.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	kernel@...gutronix.de, linux-kernel@...r.kernel.org,
	Russell King <linux@...linux.org.uk>, netdev@...r.kernel.org,
	Andre Edich <andre.edich@...rochip.com>,
	Lukas Wunner <lukas@...ner.de>
Subject: Re: [PATCH net v3 2/3] net: phy: allow drivers to disable polling
 via get_next_update_time()

On Sat, Jul 12, 2025 at 02:18:48PM +0100, Simon Horman wrote:
> > +			if (phydev->drv->update_stats) {
> > +				WARN_ONCE("phy: %s: driver requested IRQ mode but needs polling for stats\n",
> > +					  phydev_name(phydev));
> 
> The first argument to WARN_ONCE() should be a condition, not a format string.
> 
> Flagged by GCC and Clang builds with KCFLAGS=-Wformat-security

Thank you! I added it to my build test setup.

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |