netdev - Re: [PATCH 05/10] rust: drm: use `core::ffi::CStr` method names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <DBBQCHNN1N7F.3O470V9YDXE70@kernel.org>
Date: Mon, 14 Jul 2025 13:09:39 +0200
From: "Danilo Krummrich" <dakr@...nel.org>
To: "Tamir Duberstein" <tamird@...il.com>
Cc: "Maarten Lankhorst" <maarten.lankhorst@...ux.intel.com>, "Maxime Ripard"
 <mripard@...nel.org>, "Thomas Zimmermann" <tzimmermann@...e.de>, "David
 Airlie" <airlied@...il.com>, "Simona Vetter" <simona@...ll.ch>, "Miguel
 Ojeda" <ojeda@...nel.org>, "Alex Gaynor" <alex.gaynor@...il.com>, "Boqun
 Feng" <boqun.feng@...il.com>, "Gary Guo" <gary@...yguo.net>,
 Björn Roy Baron <bjorn3_gh@...tonmail.com>, "Benno Lossin"
 <lossin@...nel.org>, "Andreas Hindborg" <a.hindborg@...nel.org>, "Alice
 Ryhl" <aliceryhl@...gle.com>, "Trevor Gross" <tmgross@...ch.edu>, "Greg
 Kroah-Hartman" <gregkh@...uxfoundation.org>, "Dave Ertman"
 <david.m.ertman@...el.com>, "Ira Weiny" <ira.weiny@...el.com>, "Leon
 Romanovsky" <leon@...nel.org>, "Breno Leitao" <leitao@...ian.org>, "Rafael
 J. Wysocki" <rafael@...nel.org>, "Viresh Kumar" <viresh.kumar@...aro.org>,
 "Luis Chamberlain" <mcgrof@...nel.org>, "Russ Weight"
 <russ.weight@...ux.dev>, "Brendan Higgins" <brendan.higgins@...ux.dev>,
 "David Gow" <davidgow@...gle.com>, "Rae Moar" <rmoar@...gle.com>, "FUJITA
 Tomonori" <fujita.tomonori@...il.com>, "Rob Herring" <robh@...nel.org>,
 "Saravana Kannan" <saravanak@...gle.com>,
 <dri-devel@...ts.freedesktop.org>, <linux-kernel@...r.kernel.org>,
 <rust-for-linux@...r.kernel.org>, <linux-pm@...r.kernel.org>,
 <linux-kselftest@...r.kernel.org>, <kunit-dev@...glegroups.com>,
 <netdev@...r.kernel.org>, <devicetree@...r.kernel.org>
Subject: Re: [PATCH 05/10] rust: drm: use `core::ffi::CStr` method names

On Wed Jul 9, 2025 at 9:58 PM CEST, Tamir Duberstein wrote:
> Prepare for `core::ffi::CStr` taking the place of `kernel::str::CStr` by
> avoid methods that only exist on the latter.
>
> Link: https://github.com/Rust-for-Linux/linux/issues/1075
> Acked-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Reviewed-by: Alice Ryhl <aliceryhl@...gle.com>
> Signed-off-by: Tamir Duberstein <tamird@...il.com>
> ---
>  rust/kernel/drm/device.rs | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/rust/kernel/drm/device.rs b/rust/kernel/drm/device.rs
> index b7ee3c464a12..998b942b6dd8 100644
> --- a/rust/kernel/drm/device.rs
> +++ b/rust/kernel/drm/device.rs
> @@ -83,8 +83,8 @@ impl<T: drm::Driver> Device<T> {
>          major: T::INFO.major,
>          minor: T::INFO.minor,
>          patchlevel: T::INFO.patchlevel,
> -        name: T::INFO.name.as_char_ptr().cast_mut(),
> -        desc: T::INFO.desc.as_char_ptr().cast_mut(),
> +        name: crate::str::as_char_ptr_in_const_context(T::INFO.name).cast_mut(),
> +        desc: crate::str::as_char_ptr_in_const_context(T::INFO.desc).cast_mut(),

Maybe looks slightly cleaner to import this function, not a blocker though.