netdev - Re: [PATCH v3 08/19] net: psp: add socket security association code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <47f5b04b-fe78-4e61-8bdd-a50348ea14dd@gmail.com>
Date: Mon, 14 Jul 2025 11:10:52 -0400
From: Daniel Zahka <daniel.zahka@...il.com>
To: Willem de Bruijn <willemdebruijn.kernel@...il.com>,
 Donald Hunter <donald.hunter@...il.com>, Jakub Kicinski <kuba@...nel.org>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>,
 Jonathan Corbet <corbet@....net>, Andrew Lunn <andrew+netdev@...n.ch>
Cc: Saeed Mahameed <saeedm@...dia.com>, Leon Romanovsky <leon@...nel.org>,
 Tariq Toukan <tariqt@...dia.com>, Boris Pismenny <borisp@...dia.com>,
 Kuniyuki Iwashima <kuniyu@...gle.com>, Willem de Bruijn
 <willemb@...gle.com>, David Ahern <dsahern@...nel.org>,
 Neal Cardwell <ncardwell@...gle.com>, Patrisious Haddad
 <phaddad@...dia.com>, Raed Salem <raeds@...dia.com>,
 Jianbo Liu <jianbol@...dia.com>, Dragos Tatulea <dtatulea@...dia.com>,
 Rahul Rameshbabu <rrameshbabu@...dia.com>,
 Stanislav Fomichev <sdf@...ichev.me>,
 Toke Høiland-Jørgensen <toke@...hat.com>,
 Alexander Lobakin <aleksander.lobakin@...el.com>,
 Jacob Keller <jacob.e.keller@...el.com>, netdev@...r.kernel.org
Subject: Re: [PATCH v3 08/19] net: psp: add socket security association code

On 7/6/25 12:47 PM, Willem de Bruijn wrote:
>> +    -
>> +      name: rx-assoc
>> +      doc: Allocate a new Rx key + SPI pair, associate it with a socket.
>> +      attribute-set: assoc
>> +      do:
>> +        request:
>> +          attributes:
>> +            - dev-id
>> +            - version
>> +            - sock-fd
>> +        reply:
>> +          attributes:
>> +            - dev-id
>> +            - version
> Why return the same values as passed in the request?

version provides no information to the caller here because it is echoed 
back from the request. I will eliminate it in the next version. dev-id 
is optional in the request and looked up based on sk_dst_get() if not 
provided, so it does provide information to the caller. This socket to 
device mapping will probably be needed to respond to key rotation 
notifications, so I think keeping it around makes sense.