lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20250714082756.40ad644c@kernel.org>
Date: Mon, 14 Jul 2025 08:27:56 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Carolina Jubran <cjubran@...dia.com>
Cc: Arnd Bergmann <arnd@...nel.org>, Jiri Pirko <jiri@...nulli.us>, "David
 S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Paolo
 Abeni <pabeni@...hat.com>, Mark Bloch <mbloch@...dia.com>, Tariq Toukan
 <tariqt@...dia.com>, Arnd Bergmann <arnd@...db.de>, Simon Horman
 <horms@...nel.org>, Cosmin Ratiu <cratiu@...dia.com>, Przemek Kitszel
 <przemyslaw.kitszel@...el.com>, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [v2] devlink: move DEVLINK_ATTR_MAX-sized array off
 stack

On Sun, 13 Jul 2025 15:28:11 +0300 Carolina Jubran wrote:
> > Sure, testing it. Will update.
> 
> I have tested and it looks good. Thanks!

Awesome, would you be willing to post the official patch?
Add my as "suggested-by" and with my sign off.
Most of the work here was the testing :)

> >> diff --git a/Documentation/netlink/specs/devlink.yaml b/Documentation/ 
> >> netlink/specs/devlink.yaml
> >> index 1c4bb0cbe5f0..3d75bc530b30 100644
> >> --- a/Documentation/netlink/specs/devlink.yaml
> >> +++ b/Documentation/netlink/specs/devlink.yaml
> >> @@ -1271,12 +1259,20 @@ doc: Partial family for Devlink.
> >>           type: flag
> >>     -
> >>       name: dl-rate-tc-bws
> >> -    subset-of: devlink
> >> +    name-prefix: devlink-attr-  
> 
> Maybe use name-prefix: devlink-attr-rate-tc- instead?

Sounds good!

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ