netdev - [PATCH net-next v3 0/3] tcp: Consider every port when connecting with IP_LOCAL_PORT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20250714-connect-port-search-harder-v3-0-b1a41f249865@cloudflare.com>
Date: Mon, 14 Jul 2025 18:03:03 +0200
From: Jakub Sitnicki <jakub@...udflare.com>
To: Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, 
 "David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, 
 Neal Cardwell <ncardwell@...gle.com>, Kuniyuki Iwashima <kuniyu@...gle.com>
Cc: netdev@...r.kernel.org, kernel-team@...udflare.com, 
 Lee Valentine <lvalentine@...udflare.com>
Subject: [PATCH net-next v3 0/3] tcp: Consider every port when connecting
 with IP_LOCAL_PORT_RANGE

Please see patch 2 for details.

I stress tested it following the recipe from commit 86c2bc293b81 ("tcp: use
RCU lookup in __inet_hash_connect()"). Didn't notice any regression in
latency_mean or throughput.

Test command:

  $ vng -r ~/src/linux 'ulimit -n 40000; \
  ./tcp_crr --nolog -6 -T 80 -F 12000 >/dev/null & \
  ./tcp_crr --nolog -6 -T 80 -F 12000 -c -H ::1 -l 120 --ip-local-port-range'

neper was patched to setsockopt(IP_LOCAL_PORT_RANGE, 1 | 65535 << 16) when
--ip-local-port-range flag is set.

---
Changes in v3:
- Make (struct inet_bind_bucket *)->bhash2 RCU safe (patch 1)
- Always skip inet_bind2_bucket's with v6 wildcard sockets
- Link to v2: https://lore.kernel.org/r/20250703-connect-port-search-harder-v2-1-d51bce6bd0a6@cloudflare.com

Changes in v2:
- Fix unused var warning when CONFIG_IPV6=n
- Convert INADDR_ANY to network byte order before comparison
- Link to v1: https://lore.kernel.org/r/20250626120247.1255223-1-jakub@cloudflare.com

---
To: Eric Dumazet <edumazet@...gle.com>
To: Paolo Abeni <pabeni@...hat.com>
To: David S. Miller <davem@...emloft.net>
To: Jakub Kicinski <kuba@...nel.org>
To: Neal Cardwell <ncardwell@...gle.com>
To: Kuniyuki Iwashima <kuniyu@...gle.com>
Cc: netdev@...r.kernel.org
Cc: kernel-team@...udflare.com

---
Jakub Sitnicki (3):
      tcp: Add RCU management to inet_bind2_bucket
      tcp: Consider every port when connecting with IP_LOCAL_PORT_RANGE
      selftests/net: Cover port sharing scenarios with IP_LOCAL_PORT_RANGE

 include/net/inet_hashtables.h                      |   4 +-
 include/net/inet_timewait_sock.h                   |   3 +-
 net/ipv4/inet_connection_sock.c                    |   2 +-
 net/ipv4/inet_hashtables.c                         |  72 ++-
 net/ipv4/inet_timewait_sock.c                      |   8 +-
 tools/testing/selftests/net/ip_local_port_range.c  | 524 +++++++++++++++++++++
 tools/testing/selftests/net/ip_local_port_range.sh |  14 +-
 7 files changed, 602 insertions(+), 25 deletions(-)