netdev - Re: [PATCH net-next 09/11] ethtool: rss: support setting input-xfrm via Netlink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250714092759.3f8c77de@kernel.org>
Date: Mon, 14 Jul 2025 09:27:59 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Gal Pressman <gal@...dia.com>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
 pabeni@...hat.com, andrew+netdev@...n.ch, horms@...nel.org,
 donald.hunter@...il.com, shuah@...nel.org, kory.maincent@...tlin.com,
 maxime.chevallier@...tlin.com, sdf@...ichev.me, ecree.xilinx@...il.com
Subject: Re: [PATCH net-next 09/11] ethtool: rss: support setting input-xfrm
 via Netlink

On Sun, 13 Jul 2025 14:11:34 +0300 Gal Pressman wrote:
> > +	/* xfrm_input is NO_CHANGE AKA 0xff if per-context not supported */  
> 
> Can you please explain this comment? Shouldn't we fail in this case?
> Nit: xfrm_input -> input_xfrm.
> 
> > +	if (!request->rss_context || ops->rxfh_per_ctx_key)
> > +		xfrm_sym = !!rxfh.input_xfrm;

xfrm_sym is supposed to indicate whether input_xfrm is set to symmetric.
Normally !!input_xfrm will tell us, but if we're dealing with a request
for an RSS context and driver doesn't support per ctx key input_xfrm
will be 0xff so we'd false positive xfrm_sym and most likely fail the
SET request if the field config is not symmeric. I'll rewrite this.

BTW I have a check at netdev reg time to make sure all drivers which
support xfrm_sym and contexts also support per-context xfrm_sym, but 
it will conflict with your fix so I didn't include it, yet.