netdev - Re: [PATCH net] selftests: net: increase inter-packet timeout in udpgro.sh

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250714183206.GT721198@horms.kernel.org>
Date: Mon, 14 Jul 2025 19:32:06 +0100
From: Simon Horman <horms@...nel.org>
To: Paolo Abeni <pabeni@...hat.com>
Cc: netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Shuah Khan <shuah@...nel.org>,
	linux-kselftest@...r.kernel.org
Subject: Re: [PATCH net] selftests: net: increase inter-packet timeout in
 udpgro.sh

On Thu, Jul 10, 2025 at 06:04:50PM +0200, Paolo Abeni wrote:
> The mentioned test is not very stable when running on top of
> debug kernel build. Increase the inter-packet timeout to allow
> more slack in such environments.
> 
> Fixes: 3327a9c46352 ("selftests: add functionals test for UDP GRO")
> Signed-off-by: Paolo Abeni <pabeni@...hat.com>

As I understand it, the motivation for this patch was to make
this test more resilient [1].

[1] [TEST] net/udpgro.sh is flaky on debug
    https://lore.kernel.org/netdev/20250710070907.33d11177@kernel.org/

My observation is that it has been used since the 10th.
And that there have been no failures since the 10th [2].

In slightly more detail. The last failure was now 4 days ago.
It occurred with net-next-2025-07-10--12-00 which did not include this patch.

[2] https://netdev.bots.linux.dev/contest.html?executor=vmksft-net-dbg&test=u`dpgro-sh&ld_cnt=200&pass=0

So while it might be prudent to wait a few more days.
So far this gets my thumbs up.

Reviewed-by: Simon Horman <horms@...nel.org>