netdev - Re: [PATCH v6 bpf-next 10/12] selftests/bpf: Create established sockets in socket iterator tests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d109f0de-c857-46f6-9560-a7bd93b59bef@linux.dev>
Date: Mon, 14 Jul 2025 15:29:08 -0700
From: Martin KaFai Lau <martin.lau@...ux.dev>
To: Jordan Rife <jordan@...fe.io>
Cc: Daniel Borkmann <daniel@...earbox.net>,
 Willem de Bruijn <willemdebruijn.kernel@...il.com>,
 Kuniyuki Iwashima <kuniyu@...gle.com>,
 Alexei Starovoitov <alexei.starovoitov@...il.com>,
 Stanislav Fomichev <stfomichev@...il.com>, netdev@...r.kernel.org,
 bpf@...r.kernel.org
Subject: Re: [PATCH v6 bpf-next 10/12] selftests/bpf: Create established
 sockets in socket iterator tests

On 7/14/25 11:09 AM, Jordan Rife wrote:
> +static int *connect_to_server(int family, int sock_type, const char *addr,
> +			      __u16 port, int nr_connects, int *server_fds,
> +			      int server_fds_len)
> +{
> +	struct pollfd *server_poll_fds = NULL;
> +	struct network_helper_opts opts = {

A nit. I removed "opts" and just passed NULL to connect_to_addr_str.

I also carried Stan's ack from v4. Applied. Thanks.

> +		.timeout_ms = 0,
> +	};
> +	int *established_socks = NULL;
> +	int i;
> +
> +	server_poll_fds = calloc(server_fds_len, sizeof(*server_poll_fds));
> +	if (!ASSERT_OK_PTR(server_poll_fds, "server_poll_fds"))
> +		return NULL;
> +
> +	for (i = 0; i < server_fds_len; i++) {
> +		server_poll_fds[i].fd = server_fds[i];
> +		server_poll_fds[i].events = POLLIN;
> +	}
> +
> +	i = 0;
> +
> +	established_socks = malloc(sizeof(*established_socks) * nr_connects*2);
> +	if (!ASSERT_OK_PTR(established_socks, "established_socks"))
> +		goto error;
> +
> +	while (nr_connects--) {
> +		established_socks[i] = connect_to_addr_str(family, sock_type,
> +							   addr, port, &opts);
> +		if (!ASSERT_OK_FD(established_socks[i], "connect_to_addr_str"))
> +			goto error;
> +		i++;
> +		established_socks[i] = accept_from_one(server_poll_fds,
> +						       server_fds_len);
> +		if (!ASSERT_OK_FD(established_socks[i], "accept_from_one"))
> +			goto error;
> +		i++;
> +	}
> +
> +	free(server_poll_fds);
> +	return established_socks;
> +error:
> +	free_fds(established_socks, i);
> +	free(server_poll_fds);
> +	return NULL;
> +}