netdev - Re: [PATCH ipsec 0/2] ipsec: fix splat due to ipcomp fallback tunnel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aHSrdJoHLtp6eIGK@gauss3.secunet.de>
Date: Mon, 14 Jul 2025 09:02:12 +0200
From: Steffen Klassert <steffen.klassert@...unet.com>
To: Sabrina Dubroca <sd@...asysnail.net>
CC: <netdev@...r.kernel.org>, Herbert Xu <herbert@...dor.apana.org.au>,
	"Alexey Dobriyan" <adobriyan@...il.com>, Cong Wang <xiyou.wangcong@...il.com>
Subject: Re: [PATCH ipsec 0/2] ipsec: fix splat due to ipcomp fallback tunnel

On Fri, Jul 04, 2025 at 04:54:32PM +0200, Sabrina Dubroca wrote:
> IPcomp tunnel states have an associated fallback tunnel, a keep a
> reference on the corresponding xfrm_state, to allow deleting that
> extra state when it's not needed anymore. These states cause issues
> during netns deletion.
> 
> Commit f75a2804da39 ("xfrm: destroy xfrm_state synchronously on net
> exit path") tried to address these problems but doesn't fully solve
> them, and slowed down netns deletion by adding one synchronize_rcu per
> deleted state.
> 
> The first patch solves the problem by moving the fallback state
> deletion earlier (when we delete the user state, rather than at
> destruction), then we can revert the previous fix.
> 
> Sabrina Dubroca (2):
>   xfrm: delete x->tunnel as we delete x
>   Revert "xfrm: destroy xfrm_state synchronously on net exit path"

Series applied, thanks Sabrina!