netdev - Re: [PATCH net-next 6/6] net/mlx5e: Remove duplicate mkey from SHAMPO header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aHYFZavwYYEFtxP+@mev-dev.igk.intel.com>
Date: Tue, 15 Jul 2025 09:38:13 +0200
From: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>
To: Tariq Toukan <tariqt@...dia.com>
Cc: Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
	Paolo Abeni <pabeni@...hat.com>,
	Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Saeed Mahameed <saeed@...nel.org>, Gal Pressman <gal@...dia.com>,
	Leon Romanovsky <leon@...nel.org>,
	Saeed Mahameed <saeedm@...dia.com>, Mark Bloch <mbloch@...dia.com>,
	netdev@...r.kernel.org, linux-rdma@...r.kernel.org,
	linux-kernel@...r.kernel.org, Lama Kayal <lkayal@...dia.com>
Subject: Re: [PATCH net-next 6/6] net/mlx5e: Remove duplicate mkey from
 SHAMPO header

On Mon, Jul 14, 2025 at 08:39:45AM +0300, Tariq Toukan wrote:
> From: Lama Kayal <lkayal@...dia.com>
> 
> SHAMPO structure holds two variations of the mkey, which is unnecessary,
> a duplication that's repeated per rq.
> 
> Remove duplicate mkey information and keep only one version, the one
> used in the fast path, rename field to reflect field type clearly.
> 
> Signed-off-by: Lama Kayal <lkayal@...dia.com>
> Reviewed-by: Dragos Tatulea <dtatulea@...dia.com>
> Signed-off-by: Tariq Toukan <tariqt@...dia.com>
> ---
>  drivers/net/ethernet/mellanox/mlx5/core/en.h  |  3 +--
>  .../net/ethernet/mellanox/mlx5/core/en_main.c | 27 ++++++++++++-------
>  .../net/ethernet/mellanox/mlx5/core/en_rx.c   |  2 +-
>  3 files changed, 20 insertions(+), 12 deletions(-)

Reviewed-by: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>

Thanks

> -- 
> 2.40.1
>