netdev - Re: [PATCH net-next 2/5] gve: merge xdp and xsk registration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202507151501.qOw1iRWI-lkp@intel.com>
Date: Tue, 15 Jul 2025 16:19:49 +0800
From: kernel test robot <lkp@...el.com>
To: Jeroen de Borst <jeroendb@...gle.com>, netdev@...r.kernel.org
Cc: oe-kbuild-all@...ts.linux.dev, hramamurthy@...gle.com,
	davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	willemb@...gle.com, pabeni@...hat.com,
	Joshua Washington <joshwash@...gle.com>,
	Jeroen de Borst <jeroendb@...gle.com>
Subject: Re: [PATCH net-next 2/5] gve: merge xdp and xsk registration

Hi Jeroen,

kernel test robot noticed the following build warnings:

[auto build test WARNING on net-next/main]

url:    https://github.com/intel-lab-lkp/linux/commits/Jeroen-de-Borst/gve-deduplicate-xdp-info-and-xsk-pool-registration-logic/20250715-001243
base:   net-next/main
patch link:    https://lore.kernel.org/r/20250714160451.124671-3-jeroendb%40google.com
patch subject: [PATCH net-next 2/5] gve: merge xdp and xsk registration
config: x86_64-rhel-9.4 (https://download.01.org/0day-ci/archive/20250715/202507151501.qOw1iRWI-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14+deb12u1) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250715/202507151501.qOw1iRWI-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202507151501.qOw1iRWI-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/net/ethernet/google/gve/gve_main.c: In function 'gve_reg_xsk_pool':
>> drivers/net/ethernet/google/gve/gve_main.c:1181:29: warning: variable 'napi' set but not used [-Wunused-but-set-variable]
    1181 |         struct napi_struct *napi;
         |                             ^~~~


vim +/napi +1181 drivers/net/ethernet/google/gve/gve_main.c

013df4b1b64282 Joshua Washington 2025-07-14  1177  
013df4b1b64282 Joshua Washington 2025-07-14  1178  static int gve_reg_xsk_pool(struct gve_priv *priv, struct net_device *dev,
013df4b1b64282 Joshua Washington 2025-07-14  1179  			    struct xsk_buff_pool *pool, u16 qid)
013df4b1b64282 Joshua Washington 2025-07-14  1180  {
013df4b1b64282 Joshua Washington 2025-07-14 @1181  	struct napi_struct *napi;
013df4b1b64282 Joshua Washington 2025-07-14  1182  	struct gve_rx_ring *rx;
013df4b1b64282 Joshua Washington 2025-07-14  1183  	u16 tx_qid;
013df4b1b64282 Joshua Washington 2025-07-14  1184  	int err;
013df4b1b64282 Joshua Washington 2025-07-14  1185  
013df4b1b64282 Joshua Washington 2025-07-14  1186  	rx = &priv->rx[qid];
013df4b1b64282 Joshua Washington 2025-07-14  1187  	napi = &priv->ntfy_blocks[rx->ntfy_id].napi;
5f1e1cdb9ff911 Joshua Washington 2025-07-14  1188  	err = xdp_rxq_info_reg_mem_model(&rx->xdp_rxq,
013df4b1b64282 Joshua Washington 2025-07-14  1189  					 MEM_TYPE_XSK_BUFF_POOL, pool);
013df4b1b64282 Joshua Washington 2025-07-14  1190  	if (err) {
013df4b1b64282 Joshua Washington 2025-07-14  1191  		gve_unreg_xsk_pool(priv, qid);
013df4b1b64282 Joshua Washington 2025-07-14  1192  		return err;
013df4b1b64282 Joshua Washington 2025-07-14  1193  	}
013df4b1b64282 Joshua Washington 2025-07-14  1194  
013df4b1b64282 Joshua Washington 2025-07-14  1195  	rx->xsk_pool = pool;
013df4b1b64282 Joshua Washington 2025-07-14  1196  
013df4b1b64282 Joshua Washington 2025-07-14  1197  	tx_qid = gve_xdp_tx_queue_id(priv, qid);
013df4b1b64282 Joshua Washington 2025-07-14  1198  	priv->tx[tx_qid].xsk_pool = pool;
013df4b1b64282 Joshua Washington 2025-07-14  1199  
013df4b1b64282 Joshua Washington 2025-07-14  1200  	return 0;
013df4b1b64282 Joshua Washington 2025-07-14  1201  }
013df4b1b64282 Joshua Washington 2025-07-14  1202  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki