netdev - Re: [PATCH net-next v2 08/11] netlink: specs: define input-xfrm enum in the spec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7fe0c573-4a4d-4cff-a1c2-9d4638eea3e1@nvidia.com>
Date: Tue, 15 Jul 2025 11:35:08 +0300
From: Gal Pressman <gal@...dia.com>
To: Jakub Kicinski <kuba@...nel.org>, davem@...emloft.net
Cc: netdev@...r.kernel.org, edumazet@...gle.com, pabeni@...hat.com,
 andrew+netdev@...n.ch, horms@...nel.org, donald.hunter@...il.com,
 shuah@...nel.org, kory.maincent@...tlin.com, maxime.chevallier@...tlin.com,
 sdf@...ichev.me, ecree.xilinx@...il.com
Subject: Re: [PATCH net-next v2 08/11] netlink: specs: define input-xfrm enum
 in the spec

On 15/07/2025 1:27, Jakub Kicinski wrote:
> Help YNL decode the values for input-xfrm by defining
> the possible values in the spec. Don't define "no change"
> as it's an IOCTL artifact with no use in Netlink.
> 
> With this change on mlx5 input-xfrm gets decoded:
> 
>  # ynl --family ethtool --dump rss-get
>  [{'header': {'dev-index': 2, 'dev-name': 'eth0'},
>    'hfunc': 1,
>    'hkey': b'V\xa8\xf9\x9 ...',
>    'indir': [0, 1, ... ],
>    'input-xfrm': 'sym-or-xor',                         <<<
>    'flow-hash': {'ah4': {'ip-dst', 'ip-src'},
>                  'ah6': {'ip-dst', 'ip-src'},
>                  'esp4': {'ip-dst', 'ip-src'},
>                  'esp6': {'ip-dst', 'ip-src'},
>                  'ip4': {'ip-dst', 'ip-src'},
>                  'ip6': {'ip-dst', 'ip-src'},
>                  'tcp4': {'l4-b-0-1', 'ip-dst', 'l4-b-2-3', 'ip-src'},
>                  'tcp6': {'l4-b-0-1', 'ip-dst', 'l4-b-2-3', 'ip-src'},
>                  'udp4': {'l4-b-0-1', 'ip-dst', 'l4-b-2-3', 'ip-src'},
>                  'udp6': {'l4-b-0-1', 'ip-dst', 'l4-b-2-3', 'ip-src'}}
>  }]
> 
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>

We kinda use input_xfrm as an enum, but in theory it's a bitmask, so
while this is OK today, I'm not sure this patch is future-proof.