netdev - Re: [PATCH v3 net-next 2/2] ibmvnic: Use ndo_get_stats64 to fix inaccurate SAR reporting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250715132211.GX721198@horms.kernel.org>
Date: Tue, 15 Jul 2025 14:22:11 +0100
From: Simon Horman <horms@...nel.org>
To: Mingming Cao <mmc@...ux.ibm.com>
Cc: netdev@...r.kernel.org, kuba@...nel.org, bjking1@...ux.ibm.com,
	haren@...ux.ibm.com, ricklind@...ux.ibm.com, davemarq@...ux.ibm.com
Subject: Re: [PATCH v3 net-next 2/2] ibmvnic: Use ndo_get_stats64 to fix
 inaccurate SAR reporting

On Mon, Jul 14, 2025 at 01:35:07PM -0400, Mingming Cao wrote:
> VNIC testing on multi-core Power systems showed SAR stats drift
> and packet rate inconsistencies under load.
> 
> Implements ndo_get_stats64 to provide safe aggregation of queue-level
> atomic64 counters into rtnl_link_stats64 for use by tools like 'ip -s',
> 'ifconfig', and 'sar'. Switch to ndo_get_stats64 to align SAR reporting
> with the standard kernel interface for retrieving netdev stats.
> 
> This removes redundant per-adapter stat updates, reduces overhead,
> eliminates cacheline bouncing from hot path updates, and improves
> the accuracy of reported packet rates.
> 
> Signed-off-by: Mingming Cao <mmc@...ux.ibm.com>
> Reviewed by: Brian King <bjking1@...ux.ibm.com>
> Reviewed by: Dave Marquardt <davemarq@...ux.ibm.com>

Reviewed-by: Simon Horman <horms@...nel.org>