netdev - Re: [PATCH net-next 5/7] net: mctp: Allow limiting binds to a peer address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <13bda0930870d96ca0c27da57c9b1bf144cc89c1.camel@codeconstruct.com.au>
Date: Tue, 15 Jul 2025 09:13:35 +0800
From: Matt Johnston <matt@...econstruct.com.au>
To: Dan Carpenter <dan.carpenter@...aro.org>, oe-kbuild@...ts.linux.dev, 
 Jeremy Kerr <jk@...econstruct.com.au>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski
 <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Simon Horman
 <horms@...nel.org>
Cc: lkp@...el.com, oe-kbuild-all@...ts.linux.dev, netdev@...r.kernel.org
Subject: Re: [PATCH net-next 5/7] net: mctp: Allow limiting binds to a peer
 address

Hi,

On Mon, 2025-07-14 at 22:16 +0300, Dan Carpenter wrote:
> patch link:    https://lore.kernel.org/r/20250703-mctp-bind-v1-5-bb7e97c24613%40codeconstruct.com.au
> patch subject: [PATCH net-next 5/7] net: mctp: Allow limiting binds to a peer address
...
> smatch warnings:
> net/mctp/af_mctp.c:122 mctp_bind() warn: inconsistent returns 'sk'.
...
> d58bad174be0c4b Matt Johnston        2025-07-03   98  	if (msk->bind_peer_set) {
> d58bad174be0c4b Matt Johnston        2025-07-03   99  		if (msk->bind_type != smctp->smctp_type) {
> d58bad174be0c4b Matt Johnston        2025-07-03  100  			/* Prior connect() had a different type */
> d58bad174be0c4b Matt Johnston        2025-07-03  101  			return -EINVAL;
> 
> goto out_release?

This was fixed in the v4 series.

Cheers,  
Matt