netdev - Re: [PATCH net-next V4 1/5] net: netdevsim: hook in XDP handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f0bce278-4162-4003-bd60-072f7360d452@gmail.com>
Date: Tue, 15 Jul 2025 11:44:06 -0700
From: Mohsin Bashir <mohsin.bashr@...il.com>
To: Simon Horman <horms@...nel.org>
Cc: netdev@...r.kernel.org, kuba@...nel.org, andrew+netdev@...n.ch,
 davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com,
 shuah@...nel.org, cratiu@...dia.com, noren@...dia.com, cjubran@...dia.com,
 mbloch@...dia.com, jdamato@...tly.com, gal@...dia.com, sdf@...ichev.me,
 ast@...nel.org, daniel@...earbox.net, hawk@...nel.org,
 john.fastabend@...il.com, nathan@...nel.org,
 nick.desaulniers+lkml@...il.com, morbo@...gle.com, justinstitt@...gle.com,
 bpf@...r.kernel.org, linux-kselftest@...r.kernel.org
Subject: Re: [PATCH net-next V4 1/5] net: netdevsim: hook in XDP handling


>> +	ns = netdev_priv(dev);
>> +	xdp_prog = rcu_dereference(ns->xdp.prog);
> 
> I'm somewhat confused by this because ns->xdp.prog doesn't appear to be
> protected by RCU.
> 
> Flagged by Sparse.

Right. Thanks for pointing out Simon. I'll fix it.