netdev - Re: [RFC] Solution how to split a file in a way that git blame looks fine

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250715220654.1337102-1-kuniyu@google.com>
Date: Tue, 15 Jul 2025 22:05:39 +0000
From: Kuniyuki Iwashima <kuniyu@...gle.com>
To: przemyslaw.kitszel@...el.com
Cc: intel-wired-lan@...ts.osuosl.org, netdev@...r.kernel.org, 
	kuniyu@...gle.com
Subject: Re: [RFC] Solution how to split a file in a way that git blame looks fine

From: Przemek Kitszel <przemyslaw.kitszel@...el.com>
Date: Tue, 15 Jul 2025 22:33:40 +0200
> Hi,
> 
> I have developed (or discovered ;)) how to split a file in a way that
> both old and new are nice in terms of git-blame
> 
> https://github.com/pkitszel/linux/commits/virtchnl-split/
> 
> The purpose of RFC is to ask if anyone is in strong disagreement with me
> 
> There is more commits needed to have it nice, so it forms a git-log vs
> git-blame tradeoff, but (after the brief moment that this is on the top)
> we spend orders of magnitude more time looking at the blame output (and
> commit messages linked from that) - so I find it much better to see
> actual logic changes instead of "move xx to yy" stuff (typical for
> "squashed/single-commit splits").

FWIW, git-blame has -M/C to track X-times line moves within/across files.


> 
> Cherry-picks/rebases work the same with this method as with simple
> "squashed/single-commit" approach (literally all commits squashed into
> one (to have better git-log, but shitty git-blame output).
> 
> Rationale for the split itself is, as usual, "file is big and we want to
> extend it".
>