netdev - Re: [PATCH net-next v2 1/3] dt-bindings: sram: qcom,imem: Allow modem-tables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <62b0f514-a8a9-4147-a5c0-da9dbe13ce39@kernel.org>
Date: Tue, 15 Jul 2025 08:37:21 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Konrad Dybcio <konrad.dybcio@....qualcomm.com>,
 Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Bjorn Andersson <andersson@...nel.org>,
 Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Alex Elder <elder@...nel.org>
Cc: Marijn Suijten <marijn.suijten@...ainline.org>,
 linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
 Alex Elder <elder@...cstar.com>
Subject: Re: [PATCH net-next v2 1/3] dt-bindings: sram: qcom,imem: Allow
 modem-tables

On 14/07/2025 19:53, Konrad Dybcio wrote:
> On 5/27/25 1:42 PM, Krzysztof Kozlowski wrote:
>> On 27/05/2025 13:36, Konrad Dybcio wrote:
>>>>> diff --git a/Documentation/devicetree/bindings/sram/qcom,imem.yaml b/Documentation/devicetree/bindings/sram/qcom,imem.yaml
>>>>> index 2711f90d9664b70fcd1e2f7e2dfd3386ed5c1952..7c882819222dc04190db357ac6f9a3a35137cc9e 100644
>>>>> --- a/Documentation/devicetree/bindings/sram/qcom,imem.yaml
>>>>> +++ b/Documentation/devicetree/bindings/sram/qcom,imem.yaml
>>>>> @@ -51,6 +51,9 @@ properties:
>>>>>      $ref: /schemas/power/reset/syscon-reboot-mode.yaml#
>>>>>  
>>>>>  patternProperties:
>>>>> +  "^modem-tables@[0-9a-f]+$":
>>>>> +    description: Region reserved for the IP Accelerator
>>>>
>>>> Missing additionalProperties: false, which would point you that this is
>>>> incomplete (or useless because empty).
>>>
>>> How do I describe a 'stupid' node that is just a reg?
>> With "reg" - similarly to many syscon bindings.
> 
> Is this sort of inline style acceptable, or should I introduce
> a separate file?

It's fine, assuming that it is desired in general. We do not describe
individual memory regions of syscon nodes and this is a syscon.

If this is NVMEM (which it looks like), then could use NVMEM bindings to
describe its cells - individual regions. But otherwise we just don't.

There are many exceptions in other platforms, mostly old or even
unreviewed by DT maintainers, so they are not a recommended example.

This would need serious justification WHY you need to describe the
child. Why phandle to the main node is not enough for consumers.

If the reason is - to instantiate child device driver - then as well no.
This has been NAKed on the lists many times - you need resources if the
child should be a separate node. Address space is one resource but not
enough, because it can easily be obtained from the parent/main node.

Best regards,
Krzysztof