netdev - Re: [PATCH v4 1/3] rust: device_id: split out index support into a separate trait

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2025071607-theorize-charting-b29f@gregkh>
Date: Wed, 16 Jul 2025 11:19:15 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: FUJITA Tomonori <fujita.tomonori@...il.com>
Cc: alex.gaynor@...il.com, dakr@...nel.org, ojeda@...nel.org,
	rafael@...nel.org, robh@...nel.org, saravanak@...gle.com,
	tmgross@...ch.edu, a.hindborg@...nel.org, aliceryhl@...gle.com,
	bhelgaas@...gle.com, bjorn3_gh@...tonmail.com, boqun.feng@...il.com,
	david.m.ertman@...el.com, devicetree@...r.kernel.org,
	gary@...yguo.net, ira.weiny@...el.com, kwilczynski@...nel.org,
	lenb@...nel.org, leon@...nel.org, linux-acpi@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-pci@...r.kernel.org,
	lossin@...nel.org, netdev@...r.kernel.org,
	rust-for-linux@...r.kernel.org
Subject: Re: [PATCH v4 1/3] rust: device_id: split out index support into a
 separate trait

On Fri, Jul 11, 2025 at 01:09:45PM +0900, FUJITA Tomonori wrote:
> Introduce a new trait `RawDeviceIdIndex`, which extends `RawDeviceId`
> to provide support for device ID types that include an index or
> context field (e.g., `driver_data`). This separates the concerns of
> layout compatibility and index-based data embedding, and allows
> `RawDeviceId` to be implemented for types that do not contain a
> `driver_data` field. Several such structures are defined in
> include/linux/mod_devicetable.h.
> 
> Refactor `IdArray::new()` into a generic `build()` function, which
> takes an optional offset. Based on the presence of `RawDeviceIdIndex`,
> index writing is conditionally enabled. A new `new_without_index()`
> constructor is also provided for use cases where no index should be
> written.
> 
> This refactoring is a preparation for enabling the PHY abstractions to
> use the RawDeviceId trait.
> 
> The changes to acpi.rs and driver.rs were made by Danilo.
> 
> Acked-by: Danilo Krummrich <dakr@...nel.org>
> Reviewed-by: Trevor Gross <tmgross@...ch.edu>
> Signed-off-by: FUJITA Tomonori <fujita.tomonori@...il.com>
> ---

Acked-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>