netdev - Re: [PATCH net-next v3 06/14] octeontx2-af: Add support for SPI to SA index translation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202507170541.NbMPkGbC-lkp@intel.com>
Date: Thu, 17 Jul 2025 06:11:22 +0800
From: kernel test robot <lkp@...el.com>
To: Tanmay Jagdale <tanmay@...vell.com>, davem@...emloft.net,
	leon@...nel.org, horms@...nel.org, herbert@...dor.apana.org.au,
	sgoutham@...vell.com, bbhushan2@...vell.com
Cc: oe-kbuild-all@...ts.linux.dev, linux-crypto@...r.kernel.org,
	netdev@...r.kernel.org, Kiran Kumar K <kirankumark@...vell.com>,
	Nithin Dabilpuram <ndabilpuram@...vell.com>,
	Tanmay Jagdale <tanmay@...vell.com>
Subject: Re: [PATCH net-next v3 06/14] octeontx2-af: Add support for SPI to
 SA index translation

Hi Tanmay,

kernel test robot noticed the following build errors:

[auto build test ERROR on net-next/main]

url:    https://github.com/intel-lab-lkp/linux/commits/Tanmay-Jagdale/crypto-octeontx2-Share-engine-group-info-with-AF-driver/20250711-201723
base:   net-next/main
patch link:    https://lore.kernel.org/r/20250711121317.340326-7-tanmay%40marvell.com
patch subject: [PATCH net-next v3 06/14] octeontx2-af: Add support for SPI to SA index translation
config: sparc-allmodconfig (https://download.01.org/0day-ci/archive/20250717/202507170541.NbMPkGbC-lkp@intel.com/config)
compiler: sparc64-linux-gcc (GCC) 15.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250717/202507170541.NbMPkGbC-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202507170541.NbMPkGbC-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/net/ethernet/marvell/octeontx2/af/rvu_nix_spi.c: In function 'nix_spi_to_sa_index_check_duplicate':
>> drivers/net/ethernet/marvell/octeontx2/af/rvu_nix_spi.c:25:21: error: implicit declaration of function 'FIELD_GET' [-Wimplicit-function-declaration]
      25 |         spi_index = FIELD_GET(NIX_AF_SPI_TO_SA_SPI_INDEX_MASK, wkey);
         |                     ^~~~~~~~~
   drivers/net/ethernet/marvell/octeontx2/af/rvu_nix_spi.c: In function 'nix_spi_to_sa_index_table_update':
>> drivers/net/ethernet/marvell/octeontx2/af/rvu_nix_spi.c:53:16: error: implicit declaration of function 'FIELD_PREP' [-Wimplicit-function-declaration]
      53 |         wkey = FIELD_PREP(NIX_AF_SPI_TO_SA_SPI_INDEX_MASK, req->spi_index);
         |                ^~~~~~~~~~


vim +/FIELD_GET +25 drivers/net/ethernet/marvell/octeontx2/af/rvu_nix_spi.c

     9	
    10	static bool
    11	nix_spi_to_sa_index_check_duplicate(struct rvu *rvu,
    12					    struct nix_spi_to_sa_add_req *req,
    13					    struct nix_spi_to_sa_add_rsp *rsp,
    14					    int blkaddr, int16_t index, u8 way,
    15					    bool *is_valid, int lfidx)
    16	{
    17		u32 spi_index;
    18		u16 match_id;
    19		bool valid;
    20		u64 wkey;
    21		u8 lfid;
    22	
    23		wkey = rvu_read64(rvu, blkaddr, NIX_AF_SPI_TO_SA_KEYX_WAYX(index, way));
    24	
  > 25		spi_index = FIELD_GET(NIX_AF_SPI_TO_SA_SPI_INDEX_MASK, wkey);
    26		match_id = FIELD_GET(NIX_AF_SPI_TO_SA_MATCH_ID_MASK, wkey);
    27		lfid = FIELD_GET(NIX_AF_SPI_TO_SA_LFID_MASK, wkey);
    28		valid = FIELD_GET(NIX_AF_SPI_TO_SA_KEYX_WAYX_VALID, wkey);
    29	
    30		*is_valid = valid;
    31		if (!valid)
    32			return 0;
    33	
    34		if (req->spi_index == spi_index && req->match_id == match_id &&
    35		    lfidx == lfid) {
    36			rsp->hash_index = index;
    37			rsp->way = way;
    38			rsp->is_duplicate = true;
    39			return 1;
    40		}
    41		return 0;
    42	}
    43	
    44	static void  nix_spi_to_sa_index_table_update(struct rvu *rvu,
    45						      struct nix_spi_to_sa_add_req *req,
    46						      struct nix_spi_to_sa_add_rsp *rsp,
    47						      int blkaddr, int16_t index,
    48						      u8 way, int lfidx)
    49	{
    50		u64 wvalue;
    51		u64 wkey;
    52	
  > 53		wkey = FIELD_PREP(NIX_AF_SPI_TO_SA_SPI_INDEX_MASK, req->spi_index);
    54		wkey |= FIELD_PREP(NIX_AF_SPI_TO_SA_MATCH_ID_MASK, req->match_id);
    55		wkey |= FIELD_PREP(NIX_AF_SPI_TO_SA_LFID_MASK, lfidx);
    56		wkey |= FIELD_PREP(NIX_AF_SPI_TO_SA_KEYX_WAYX_VALID, req->valid);
    57	
    58		rvu_write64(rvu, blkaddr, NIX_AF_SPI_TO_SA_KEYX_WAYX(index, way),
    59			    wkey);
    60		wvalue = (req->sa_index & 0xFFFFFFFF);
    61		rvu_write64(rvu, blkaddr, NIX_AF_SPI_TO_SA_VALUEX_WAYX(index, way),
    62			    wvalue);
    63		rsp->hash_index = index;
    64		rsp->way = way;
    65		rsp->is_duplicate = false;
    66	}
    67	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki