netdev - Re: [PATCH v2 net-next 1/2] net: Prevent RPS table overwrite for active flows

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202507161125.rUCoz9ov-lkp@intel.com>
Date: Wed, 16 Jul 2025 12:20:07 +0800
From: kernel test robot <lkp@...el.com>
To: Krishna Kumar <krikku@...il.com>, netdev@...r.kernel.org,
	davem@...emloft.net, edumazet@...gle.com
Cc: oe-kbuild-all@...ts.linux.dev, tom@...bertland.com, kuba@...nel.org,
	pabeni@...hat.com, horms@...nel.org, sdf@...ichev.me,
	kuniyu@...gle.com, ahmed.zaki@...el.com,
	aleksander.lobakin@...el.com, atenart@...nel.org,
	jdamato@...tly.com, krishna.ku@...pkart.com
Subject: Re: [PATCH v2 net-next 1/2] net: Prevent RPS table overwrite for
 active flows

Hi Krishna,

kernel test robot noticed the following build warnings:

[auto build test WARNING on net-next/main]

url:    https://github.com/intel-lab-lkp/linux/commits/Krishna-Kumar/net-Prevent-RPS-table-overwrite-for-active-flows/20250715-192710
base:   net-next/main
patch link:    https://lore.kernel.org/r/20250715112431.2178100-2-krikku%40gmail.com
patch subject: [PATCH v2 net-next 1/2] net: Prevent RPS table overwrite for active flows
config: arc-randconfig-002-20250716 (https://download.01.org/0day-ci/archive/20250716/202507161125.rUCoz9ov-lkp@intel.com/config)
compiler: arc-linux-gcc (GCC) 8.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250716/202507161125.rUCoz9ov-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202507161125.rUCoz9ov-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> net/core/dev.c:4853:13: warning: 'rps_flow_is_active' defined but not used [-Wunused-function]
    static bool rps_flow_is_active(struct rps_dev_flow *rflow,
                ^~~~~~~~~~~~~~~~~~


vim +/rps_flow_is_active +4853 net/core/dev.c

  4839	
  4840	/**
  4841	 * rps_flow_is_active - check whether the flow is recently active.
  4842	 * @rflow: Specific flow to check activity.
  4843	 * @flow_table: Check activity against the flow_table's size.
  4844	 * @cpu: CPU saved in @rflow.
  4845	 *
  4846	 * If the CPU has processed many packets since the flow's last activity
  4847	 * (beyond 10 times the table size), the flow is considered stale.
  4848	 *
  4849	 * Return values:
  4850	 *	True:  Flow has recent activity.
  4851	 *	False: Flow does not have recent activity.
  4852	 */
> 4853	static bool rps_flow_is_active(struct rps_dev_flow *rflow,
  4854				       struct rps_dev_flow_table *flow_table,
  4855				       unsigned int cpu)
  4856	{
  4857		return cpu < nr_cpu_ids &&
  4858		       ((int)(READ_ONCE(per_cpu(softnet_data, cpu).input_queue_head) -
  4859			READ_ONCE(rflow->last_qtail)) < (int)(10 << flow_table->log));
  4860	}
  4861	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki