netdev - Re: [PATCH net-next 2/2] net: hibmcge: Add support for PHY LEDs on YT8521

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3e773022-8be8-42c4-9920-48336bf7c365@huawei.com>
Date: Thu, 17 Jul 2025 16:39:56 +0800
From: Jijie Shao <shaojijie@...wei.com>
To: Andrew Lunn <andrew@...n.ch>
CC: <shaojijie@...wei.com>, <davem@...emloft.net>, <edumazet@...gle.com>,
	<kuba@...nel.org>, <pabeni@...hat.com>, <andrew+netdev@...n.ch>,
	<horms@...nel.org>, <Frank.Sae@...or-comm.com>, <hkallweit1@...il.com>,
	<linux@...linux.org.uk>, <shenjian15@...wei.com>, <liuyonglong@...wei.com>,
	<chenhao418@...wei.com>, <jonathan.cameron@...wei.com>,
	<shameerali.kolothum.thodi@...wei.com>, <salil.mehta@...wei.com>,
	<netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next 2/2] net: hibmcge: Add support for PHY LEDs on
 YT8521


on 2025/7/17 0:42, Andrew Lunn wrote:
> On Wed, Jul 16, 2025 at 06:00:41PM +0800, Jijie Shao wrote:
>> hibmcge is a PCIE EP device, and its controller is
>> not on the board. And board uses ACPI not DTS
>> to create the device tree.
>>
>> So, this makes it impossible to add a "reg" property(used in of_phy_led())
>> for hibmcge. Therefore, the PHY_LED framework cannot be used directly.
>>
>> This patch creates a separate LED device for hibmcge
>> and directly calls the phy->drv->led_hw**() function to
>> operate the related LEDs.
> Extending what Russell said, please take a look at:
>
> Documentation/firmware-guide/acpi/dsd/phy.rst
>
> and extend it to cover PHY LEDs.
>
> 	Andrew

Sure. I'll take a look at this.

Thanks,
Jijie Shao