netdev - Re: [PATCH net-next v3 3/3] selftests/net: Cover port sharing scenarios with IP_LOCAL_PORT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87ms93dudi.fsf@cloudflare.com>
Date: Thu, 17 Jul 2025 11:44:25 +0200
From: Jakub Sitnicki <jakub@...udflare.com>
To: Paolo Abeni <pabeni@...hat.com>
Cc: Eric Dumazet <edumazet@...gle.com>,  "David S. Miller"
 <davem@...emloft.net>,  Jakub Kicinski <kuba@...nel.org>,  Neal Cardwell
 <ncardwell@...gle.com>,  Kuniyuki Iwashima <kuniyu@...gle.com>,
  netdev@...r.kernel.org,  kernel-team@...udflare.com
Subject: Re: [PATCH net-next v3 3/3] selftests/net: Cover port sharing
 scenarios with IP_LOCAL_PORT_RANGE

On Thu, Jul 17, 2025 at 11:27 AM +02, Paolo Abeni wrote:
> On 7/14/25 6:03 PM, Jakub Sitnicki wrote:
>> diff --git a/tools/testing/selftests/net/ip_local_port_range.sh b/tools/testing/selftests/net/ip_local_port_range.sh
>> index 4ff746db1256..3fc151545b2d 100755
>> --- a/tools/testing/selftests/net/ip_local_port_range.sh
>> +++ b/tools/testing/selftests/net/ip_local_port_range.sh
>> @@ -1,7 +1,11 @@
>> -#!/bin/sh
>> +#!/bin/bash
>>  # SPDX-License-Identifier: GPL-2.0
>>  
>> -./in_netns.sh \
>> -  sh -c 'sysctl -q -w net.mptcp.enabled=1 && \
>> -         sysctl -q -w net.ipv4.ip_local_port_range="40000 49999" && \
>> -         ./ip_local_port_range'
>> +./in_netns.sh sh <(cat <<-EOF
>> +        sysctl -q -w net.mptcp.enabled=1
>> +        sysctl -q -w net.ipv4.ip_local_port_range="40000 49999"
>> +        ip -6 addr add dev lo 2001:db8::1/32 nodad
>> +        ip -6 addr add dev lo 2001:db8::2/32 nodad
>> +        exec ./ip_local_port_range
>
> Minor nit: it looks like you could simply add the additional statements
> to the '-c' argument without changing the used shell.

I might have gone overboard here. Will revert.