netdev - Re: [PATCH v2 net-next 02/14] dt-bindings: net: add nxp,netc-timer property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <af75073c-4ce8-44c1-9e48-b22902373e81@kernel.org>
Date: Thu, 17 Jul 2025 12:06:40 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Wei Fang <wei.fang@....com>
Cc: "robh@...nel.org" <robh@...nel.org>,
 "krzk+dt@...nel.org" <krzk+dt@...nel.org>,
 "conor+dt@...nel.org" <conor+dt@...nel.org>,
 "richardcochran@...il.com" <richardcochran@...il.com>,
 Claudiu Manoil <claudiu.manoil@....com>,
 Vladimir Oltean <vladimir.oltean@....com>, Clark Wang
 <xiaoning.wang@....com>, "andrew+netdev@...n.ch" <andrew+netdev@...n.ch>,
 "davem@...emloft.net" <davem@...emloft.net>,
 "edumazet@...gle.com" <edumazet@...gle.com>,
 "kuba@...nel.org" <kuba@...nel.org>, "pabeni@...hat.com"
 <pabeni@...hat.com>, "vadim.fedorenko@...ux.dev"
 <vadim.fedorenko@...ux.dev>, Frank Li <frank.li@....com>,
 "shawnguo@...nel.org" <shawnguo@...nel.org>,
 "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
 "festevam@...il.com" <festevam@...il.com>, "F.S. Peng" <fushi.peng@....com>,
 "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
 "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "imx@...ts.linux.dev" <imx@...ts.linux.dev>,
 "kernel@...gutronix.de" <kernel@...gutronix.de>
Subject: Re: [PATCH v2 net-next 02/14] dt-bindings: net: add nxp,netc-timer
 property

On 17/07/2025 11:49, Wei Fang wrote:
>>>
>>> I do not think it is timestamper. Each ENETC has the ability to record
>>> the sending/receiving timestamp of the packets on the Tx/Rx BD, but
>>> the timestamp comes from the Timer. For platforms have multiple Timer
>>
>> Isn't this exactly what timestamper is supposed to do?
>>
> According to the definition, timestamper requires two parameters, one is
> the node reference and the other is the port, and the timestamper is added
> to the PHY node, and is used by the gerneric mdio driver. The PTP driver

We do not speak about drivers.

> provides the interfaces of mii_timestamping_ctrl. So this property is to
> provide PTP support for PHY devices.
> 
> 
> timestamper:	provides control node reference and
> 			the port channel within the IP core
> 
> The "timestamper" property lives in a phy node and links a time
> stamping channel from the controller device to that phy's MII bus.
> 
> But for NETC, we only need the node parameter, and this property is
> added to the MAC node.

I think we do not understand each other. I ask if this is the
timestamper and you explain about arguments of the phandle. The
arguments are not relevant.

What is this purpose/role/function of the timer device?

What is the purpose of this new property in the binding here?

Best regards,
Krzysztof