netdev - RE: [PATCH v2 net-next 01/14] dt-bindings: ptp: add NETC Timer PTP clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <PAXPR04MB8510F1755A7EFF016394FCCF8851A@PAXPR04MB8510.eurprd04.prod.outlook.com>
Date: Thu, 17 Jul 2025 10:28:31 +0000
From: Wei Fang <wei.fang@....com>
To: Krzysztof Kozlowski <krzk@...nel.org>
CC: "robh@...nel.org" <robh@...nel.org>, "krzk+dt@...nel.org"
	<krzk+dt@...nel.org>, "conor+dt@...nel.org" <conor+dt@...nel.org>,
	"richardcochran@...il.com" <richardcochran@...il.com>, Claudiu Manoil
	<claudiu.manoil@....com>, Vladimir Oltean <vladimir.oltean@....com>, Clark
 Wang <xiaoning.wang@....com>, "andrew+netdev@...n.ch"
	<andrew+netdev@...n.ch>, "davem@...emloft.net" <davem@...emloft.net>,
	"edumazet@...gle.com" <edumazet@...gle.com>, "kuba@...nel.org"
	<kuba@...nel.org>, "pabeni@...hat.com" <pabeni@...hat.com>,
	"vadim.fedorenko@...ux.dev" <vadim.fedorenko@...ux.dev>, Frank Li
	<frank.li@....com>, "shawnguo@...nel.org" <shawnguo@...nel.org>,
	"s.hauer@...gutronix.de" <s.hauer@...gutronix.de>, "festevam@...il.com"
	<festevam@...il.com>, "F.S. Peng" <fushi.peng@....com>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"imx@...ts.linux.dev" <imx@...ts.linux.dev>, "kernel@...gutronix.de"
	<kernel@...gutronix.de>
Subject: RE: [PATCH v2 net-next 01/14] dt-bindings: ptp: add NETC Timer PTP
 clock

> On 17/07/2025 10:30, Wei Fang wrote:
> >> On Wed, Jul 16, 2025 at 03:30:58PM +0800, Wei Fang wrote:
> >>> +properties:
> >>> +  compatible:
> >>> +    enum:
> >>> +      - pci1131,ee02
> >>> +
> >>> +  reg:
> >>> +    maxItems: 1
> >>> +
> >>> +  clocks:
> >>> +    maxItems: 1
> >>> +    description:
> >>> +      The reference clock of NETC Timer, if not present, indicates that
> >>> +      the system clock of NETC IP is selected as the reference clock.
> >>
> >> If not present...
> >>
> >>> +
> >>> +  clock-names:
> >>
> >> ... this also is not present...
> >>
> >>> +    description:
> >>> +      NETC Timer has three reference clock sources, set
> >> TMR_CTRL[CK_SEL]
> >>> +      by parsing clock name to select one of them as the reference clock.
> >>> +      The "system" means that the system clock of NETC IP is used as the
> >>> +      reference clock.
> >>> +      The "ccm_timer" means another clock from CCM as the reference
> >> clock.
> >>> +      The "ext_1588" means the reference clock comes from external IO
> >> pins.
> >>> +    enum:
> >>> +      - system
> >>
> >> So what does system mean?
> >>
> >
> > "system" is the system clock of the NETC subsystem, we can explicitly specify
> > this clock as the PTP reference clock of the Timer in the DT node. Or do not
> > add clock properties to the DT node, it implicitly indicates that the reference
> > clock of the Timer is the "system" clock.
> >
> 
> Eh, no. If absence of clock input means you are using specific clock
> input it is contradictory to the first. You cannot use some clock input
> if you claim that it can be missing.
> 
> You define here clock inputs. This is what this property is about.
> 

Okay, I will remove "system", due to it is the system clock of NETC IP,
which is always available to Timer.