netdev - Re: [PATCH v23 net-next 1/6] sched: Struct definition and parsing of dualpi2 qdisc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250717063854.52ea7371@kernel.org>
Date: Thu, 17 Jul 2025 06:38:54 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: "Chia-Yu Chang (Nokia)" <chia-yu.chang@...ia-bell-labs.com>
Cc: "alok.a.tiwari@...cle.com" <alok.a.tiwari@...cle.com>,
 "pctammela@...atatu.com" <pctammela@...atatu.com>, "horms@...nel.org"
 <horms@...nel.org>, "donald.hunter@...il.com" <donald.hunter@...il.com>,
 "xandfury@...il.com" <xandfury@...il.com>, "netdev@...r.kernel.org"
 <netdev@...r.kernel.org>, "dave.taht@...il.com" <dave.taht@...il.com>,
 "pabeni@...hat.com" <pabeni@...hat.com>, "jhs@...atatu.com"
 <jhs@...atatu.com>, "stephen@...workplumber.org"
 <stephen@...workplumber.org>, "xiyou.wangcong@...il.com"
 <xiyou.wangcong@...il.com>, "jiri@...nulli.us" <jiri@...nulli.us>,
 "davem@...emloft.net" <davem@...emloft.net>, "edumazet@...gle.com"
 <edumazet@...gle.com>, "andrew+netdev@...n.ch" <andrew+netdev@...n.ch>,
 "ast@...erby.net" <ast@...erby.net>, "liuhangbin@...il.com"
 <liuhangbin@...il.com>, "shuah@...nel.org" <shuah@...nel.org>,
 "linux-kselftest@...r.kernel.org" <linux-kselftest@...r.kernel.org>,
 "ij@...nel.org" <ij@...nel.org>, "ncardwell@...gle.com"
 <ncardwell@...gle.com>, "Koen De Schepper (Nokia)"
 <koen.de_schepper@...ia-bell-labs.com>, "g.white@...lelabs.com"
 <g.white@...lelabs.com>, "ingemar.s.johansson@...csson.com"
 <ingemar.s.johansson@...csson.com>, "mirja.kuehlewind@...csson.com"
 <mirja.kuehlewind@...csson.com>, "cheshire@...le.com" <cheshire@...le.com>,
 "rs.ietf@....at" <rs.ietf@....at>, "Jason_Livingood@...cast.com"
 <Jason_Livingood@...cast.com>, "vidhi_goel@...le.com"
 <vidhi_goel@...le.com>
Subject: Re: [PATCH v23 net-next 1/6] sched: Struct definition and parsing
 of dualpi2 qdisc

On Thu, 17 Jul 2025 07:16:21 +0000 Chia-Yu Chang (Nokia) wrote:
> Thanks for feedback.
> May I ask is it fine if I put the enum like below?
> 
> enum tc_dualpi2_drop_overload {
>        TC_DUALPI2_DROP_OVERLOAD_OVERFLOW = 0,
>        TC_DUALPI2_DROP_OVERLOAD_DROP = 1,
>        __TCA_DUALPI2_DROP_OVERLOAD_MAX,
> };
> #define TCA_DUALPI2_DROP_OVERLOAD_MAX (__TCA_DUALPI2_DROP_OVERLOAD_MAX - 1)

Missed the TCA_ on the max entry and define?

> enum tc_dualpi2_drop_early {
>        TC_DUALPI2_DROP_EARLY_DROP_DEQUEUE = 0,
>        TC_DUALPI2_DROP_EARLY_DROP_ENQUEUE = 1,
>        __TCA_DUALPI2_DROP_EARLY_MAX,
> };
> #define TCA_DUALPI2_DROP_EARLY_MAX (__TCA_DUALPI2_DROP_EARLY_MAX - 1)
> 
> enum tc_dualpi2_ecn_mask {
>        TC_DUALPI2_ECN_MASK_L4S_ECT = 1,
>        TC_DUALPI2_ECN_MASK_CLA_ECT = 2,
>        TC_DUALPI2_ECN_MASK_ANY_ECT = 3,
>        __TCA_DUALPI2_ECN_MASK_MAX,
> };
> #define TCA_DUALPI2_ECN_MASK_MAX (__TCA_DUALPI2_ECN_MASK_MAX - 1)
> 
> enum tc_dualpi2_split_gso {
>        TC_DUALPI2_SPLIT_GSO_NO_SPLIT_GSO = 0,
>        TC_DUALPI2_SPLIT_GSO_SPLIT_GSO = 1,
>        __TCA_DUALPI2_SPLIT_GSO_MAX,
> };
> #define TCA_DUALPI2_SPLIT_GSO_MAX (__TCA_DUALPI2_SPLIT_GSO_MAX - 1)
>  
>  
> And shall such change also been applied to Dualpi2 attributes below?
> As these are more attribute-like, so I assume no.

Correct, these stay as they are.