netdev - Re: [PATCH net v3] virtio-net: fix recursived rtnl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACGkMEsSD_r0akWpsP+Xa4_CvCAEVbF2cQ9GrE6VYhZ7m2C9hA@mail.gmail.com>
Date: Thu, 17 Jul 2025 10:02:22 +0800
From: Jason Wang <jasowang@...hat.com>
To: Zigit Zo <zuozhijie@...edance.com>
Cc: mst@...hat.com, xuanzhuo@...ux.alibaba.com, eperezma@...hat.com, 
	virtualization@...ts.linux.dev, netdev@...r.kernel.org, 
	linux-kernel@...r.kernel.org, kuba@...nel.org, pabeni@...hat.com, 
	andrew+netdev@...n.ch, edumazet@...gle.com
Subject: Re: [PATCH net v3] virtio-net: fix recursived rtnl_lock() during probe()

On Wed, Jul 16, 2025 at 7:57 PM Zigit Zo <zuozhijie@...edance.com> wrote:
>
> The deadlock appears in a stack trace like:
>
>   virtnet_probe()
>     rtnl_lock()
>     virtio_config_changed_work()
>       netdev_notify_peers()
>         rtnl_lock()
>
> It happens if the VMM sends a VIRTIO_NET_S_ANNOUNCE request while the
> virtio-net driver is still probing.
>
> The config_work in probe() will get scheduled until virtnet_open() enables
> the config change notification via virtio_config_driver_enable().
>
> Fixes: df28de7b0050 ("virtio-net: synchronize operstate with admin state on up/down")
> Signed-off-by: Zigit Zo <zuozhijie@...edance.com>
> ---

Acked-by: Jason Wang <jasowang@...hat.com>

Thanks