netdev - Re: [GIT PULL] bluetooth 2025-07-17

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250717085444.2847ac02@kernel.org>
Date: Thu, 17 Jul 2025 08:54:44 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Luiz Augusto von Dentz <luiz.dentz@...il.com>
Cc: davem@...emloft.net, linux-bluetooth@...r.kernel.org,
 netdev@...r.kernel.org
Subject: Re: [GIT PULL] bluetooth 2025-07-17

On Thu, 17 Jul 2025 11:47:49 -0400 Luiz Augusto von Dentz wrote:
> > On Thu, 17 Jul 2025 10:28:49 -0400 Luiz Augusto von Dentz wrote:  
> > >       Bluetooth: hci_dev: replace 'quirks' integer by 'quirk_flags' bitmap  
> >
> > FTR this rename and adding the helpers does not seem to be very
> > necessary for the fix? I know Greg says that we shouldn't intentionally
> > try to make fixes small, but there's a fine line between following that
> > and coincidental code refactoring.  
> 
> I should have reworded that commit, it is actually a fix, not just
> renaming, we run out of bits on a 32 bits system due to usage of int
> as storage.

Right, but I think if the new bitmap was called quirks the existing
set_bit / test_bit call sites would have been just fine, right?
The bit ops operate on single ulong and bitmaps all the same.