netdev - RE: [PATCH v23 net-next 1/6] sched: Struct definition and parsing of dualpi2 qdisc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID:
 <PAXPR07MB7984AFFA35DA43805C02E542A351A@PAXPR07MB7984.eurprd07.prod.outlook.com>
Date: Thu, 17 Jul 2025 07:16:21 +0000
From: "Chia-Yu Chang (Nokia)" <chia-yu.chang@...ia-bell-labs.com>
To: Jakub Kicinski <kuba@...nel.org>
CC: "alok.a.tiwari@...cle.com" <alok.a.tiwari@...cle.com>,
	"pctammela@...atatu.com" <pctammela@...atatu.com>, "horms@...nel.org"
	<horms@...nel.org>, "donald.hunter@...il.com" <donald.hunter@...il.com>,
	"xandfury@...il.com" <xandfury@...il.com>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "dave.taht@...il.com" <dave.taht@...il.com>,
	"pabeni@...hat.com" <pabeni@...hat.com>, "jhs@...atatu.com"
	<jhs@...atatu.com>, "stephen@...workplumber.org"
	<stephen@...workplumber.org>, "xiyou.wangcong@...il.com"
	<xiyou.wangcong@...il.com>, "jiri@...nulli.us" <jiri@...nulli.us>,
	"davem@...emloft.net" <davem@...emloft.net>, "edumazet@...gle.com"
	<edumazet@...gle.com>, "andrew+netdev@...n.ch" <andrew+netdev@...n.ch>,
	"ast@...erby.net" <ast@...erby.net>, "liuhangbin@...il.com"
	<liuhangbin@...il.com>, "shuah@...nel.org" <shuah@...nel.org>,
	"linux-kselftest@...r.kernel.org" <linux-kselftest@...r.kernel.org>,
	"ij@...nel.org" <ij@...nel.org>, "ncardwell@...gle.com"
	<ncardwell@...gle.com>, "Koen De Schepper (Nokia)"
	<koen.de_schepper@...ia-bell-labs.com>, "g.white@...lelabs.com"
	<g.white@...lelabs.com>, "ingemar.s.johansson@...csson.com"
	<ingemar.s.johansson@...csson.com>, "mirja.kuehlewind@...csson.com"
	<mirja.kuehlewind@...csson.com>, "cheshire@...le.com" <cheshire@...le.com>,
	"rs.ietf@....at" <rs.ietf@....at>, "Jason_Livingood@...cast.com"
	<Jason_Livingood@...cast.com>, "vidhi_goel@...le.com" <vidhi_goel@...le.com>
Subject: RE: [PATCH v23 net-next 1/6] sched: Struct definition and parsing of
 dualpi2 qdisc

> -----Original Message-----
> From: Jakub Kicinski <kuba@...nel.org> 
> Sent: Thursday, July 17, 2025 1:46 AM
> To: Chia-Yu Chang (Nokia) <chia-yu.chang@...ia-bell-labs.com>
> Cc: alok.a.tiwari@...cle.com; pctammela@...atatu.com; horms@...nel.org; donald.hunter@...il.com; xandfury@...il.com; netdev@...r.kernel.org; dave.taht@...il.com; pabeni@...hat.com; jhs@...atatu.com; stephen@...workplumber.org; xiyou.wangcong@...il.com; jiri@...nulli.us; davem@...emloft.net; edumazet@...gle.com; andrew+netdev@...n.ch; ast@...erby.net; liuhangbin@...il.com; shuah@...nel.org; linux-kselftest@...r.kernel.org; ij@...nel.org; ncardwell@...gle.com; Koen De Schepper (Nokia) <koen.de_schepper@...ia-bell-labs.com>; g.white@...lelabs.com; ingemar.s.johansson@...csson.com; mirja.kuehlewind@...csson.com; cheshire@...le.com; rs.ietf@....at; Jason_Livingood@...cast.com; vidhi_goel@...le.com
> Subject: Re: [PATCH v23 net-next 1/6] sched: Struct definition and parsing of dualpi2 qdisc
> 
> 
> CAUTION: This is an external email. Please be very careful when clicking links or opening attachments. See the URL nok.it/ext for additional information.
> 
> 
> 
> On Sun, 13 Jul 2025 12:52:29 +0200 chia-yu.chang@...ia-bell-labs.com
> wrote:
> > +/* DUALPI2 */
> > +enum tc_dualpi2_drop_overload {
> > +     TCA_DUALPI2_DROP_OVERLOAD_OVERFLOW = 0,
> > +     TCA_DUALPI2_DROP_OVERLOAD_DROP = 1,
> > +     __TCA_DUALPI2_DROP_OVERLOAD_MAX, }; #define 
> > +TCA_DUALPI2_DROP_OVERLOAD_MAX (__TCA_DUALPI2_DROP_OVERLOAD_MAX - 1)
> > +
> > +enum tc_dualpi2_drop_early {
> > +     TCA_DUALPI2_DROP_EARLY_DROP_DEQUEUE = 0,
> > +     TCA_DUALPI2_DROP_EARLY_DROP_ENQUEUE = 1,
> > +     __TCA_DUALPI2_DROP_EARLY_MAX,
> > +};
> > +#define TCA_DUALPI2_DROP_EARLY_MAX (__TCA_DUALPI2_DROP_EARLY_MAX - 1)
> > +
> > +enum tc_dualpi2_ecn_mask {
> > +     TCA_DUALPI2_ECN_MASK_L4S_ECT = 1,
> > +     TCA_DUALPI2_ECN_MASK_CLA_ECT = 2,
> > +     TCA_DUALPI2_ECN_MASK_ANY_ECT = 3,
> > +     __TCA_DUALPI2_ECN_MASK_MAX,
> > +};
> > +#define TCA_DUALPI2_ECN_MASK_MAX (__TCA_DUALPI2_ECN_MASK_MAX - 1)
> > +
> > +enum tc_dualpi2_split_gso {
> > +     TCA_DUALPI2_SPLIT_GSO_NO_SPLIT_GSO = 0,
> > +     TCA_DUALPI2_SPLIT_GSO_SPLIT_GSO = 1,
> > +     __TCA_DUALPI2_SPLIT_GSO_MAX,
> > +};
> > +#define TCA_DUALPI2_SPLIT_GSO_MAX (__TCA_DUALPI2_SPLIT_GSO_MAX - 1)
> 
> Looks like you fixed the type name but not the entry names :( Once again, TCA_ stands for TC Attribute. These are not attribute IDs but values. YNL will expect them to be prefixed with TC_DUALPI2, for example:
> 
> static const char * const tc_dualpi2_ecn_mask_strmap[] = {
>         [TC_DUALPI2_ECN_MASK_L4S_ECT] = "l4s-ect",
>         [TC_DUALPI2_ECN_MASK_CLA_ECT] = "cla-ect",
>         [TC_DUALPI2_ECN_MASK_ANY_ECT] = "any-ect", };
> 
> Only the last enum you're adding in this file, which defines the attributes IDs should use the TCA_ prefix.

Thanks for feedback.
May I ask is it fine if I put the enum like below?

enum tc_dualpi2_drop_overload {
       TC_DUALPI2_DROP_OVERLOAD_OVERFLOW = 0,
       TC_DUALPI2_DROP_OVERLOAD_DROP = 1,
       __TCA_DUALPI2_DROP_OVERLOAD_MAX,
};
#define TCA_DUALPI2_DROP_OVERLOAD_MAX (__TCA_DUALPI2_DROP_OVERLOAD_MAX - 1)

enum tc_dualpi2_drop_early {
       TC_DUALPI2_DROP_EARLY_DROP_DEQUEUE = 0,
       TC_DUALPI2_DROP_EARLY_DROP_ENQUEUE = 1,
       __TCA_DUALPI2_DROP_EARLY_MAX,
};
#define TCA_DUALPI2_DROP_EARLY_MAX (__TCA_DUALPI2_DROP_EARLY_MAX - 1)

enum tc_dualpi2_ecn_mask {
       TC_DUALPI2_ECN_MASK_L4S_ECT = 1,
       TC_DUALPI2_ECN_MASK_CLA_ECT = 2,
       TC_DUALPI2_ECN_MASK_ANY_ECT = 3,
       __TCA_DUALPI2_ECN_MASK_MAX,
};
#define TCA_DUALPI2_ECN_MASK_MAX (__TCA_DUALPI2_ECN_MASK_MAX - 1)

enum tc_dualpi2_split_gso {
       TC_DUALPI2_SPLIT_GSO_NO_SPLIT_GSO = 0,
       TC_DUALPI2_SPLIT_GSO_SPLIT_GSO = 1,
       __TCA_DUALPI2_SPLIT_GSO_MAX,
};
#define TCA_DUALPI2_SPLIT_GSO_MAX (__TCA_DUALPI2_SPLIT_GSO_MAX - 1)
 
 
And shall such change also been applied to Dualpi2 attributes below? As these are more attribute-like, so I assume no.

enum {
        TCA_DUALPI2_UNSPEC,
        TCA_DUALPI2_LIMIT,              /* Packets */
        TCA_DUALPI2_MEMORY_LIMIT,       /* Bytes */
        TCA_DUALPI2_TARGET,             /* us */
        TCA_DUALPI2_TUPDATE,            /* us */
        TCA_DUALPI2_ALPHA,              /* Hz scaled up by 256 */
        TCA_DUALPI2_BETA,               /* Hz scaled up by 256 */
        TCA_DUALPI2_STEP_THRESH_PKTS,   /* Step threshold in packets */
        TCA_DUALPI2_STEP_THRESH_US,     /* Step threshold in microseconds */
        TCA_DUALPI2_MIN_QLEN_STEP,      /* Minimum qlen to apply STEP_THRESH */
        TCA_DUALPI2_COUPLING,           /* Coupling factor between queues */
        TCA_DUALPI2_DROP_OVERLOAD,      /* Whether to drop on overload */
        TCA_DUALPI2_DROP_EARLY,         /* Whether to drop on enqueue */
        TCA_DUALPI2_C_PROTECTION,       /* Percentage */
        TCA_DUALPI2_ECN_MASK,           /* L4S queue classification mask */
        TCA_DUALPI2_SPLIT_GSO,          /* Split GSO packets at enqueue */
        TCA_DUALPI2_PAD,
        __TCA_DUALPI2_MAX
};

#define TCA_DUALPI2_MAX   (__TCA_DUALPI2_MAX - 1)