netdev - Re: [PATCH iwl-next] idpf: set napi for each TX and RX queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9b1b668e-19a0-4191-a5c7-686e05a08a80@intel.com>
Date: Fri, 18 Jul 2025 15:06:48 +0200
From: Alexander Lobakin <aleksander.lobakin@...el.com>
To: Tony Nguyen <anthony.l.nguyen@...el.com>, Samiullah Khawaja
	<skhawaja@...gle.com>
CC: Przemek Kitszel <przemyslaw.kitszel@...el.com>, "David S. Miller"
	<davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski
	<kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	<intel-wired-lan@...ts.osuosl.org>, <willemb@...gle.com>,
	<almasrymina@...gle.com>, David Decotigny <decot@...gle.com>, Anjali Singhai
	<anjali.singhai@...el.com>, Sridhar Samudrala <sridhar.samudrala@...el.com>,
	<linux-kernel@...r.kernel.org>, <netdev@...r.kernel.org>,
	<emil.s.tantilov@...el.com>
Subject: Re: [PATCH iwl-next] idpf: set napi for each TX and RX queue

From: Tony Nguyen <anthony.l.nguyen@...el.com>
Date: Thu, 17 Jul 2025 13:25:05 -0700

> 
> 
> On 7/16/2025 2:12 PM, Samiullah Khawaja wrote:
>> Use netif_queue_set_napi to associate TX/RX queues to the relevant napi.
>> This allows fetching napi for a TX or RX queue using netlink queue-get
>> op.
>>
>> Tested:
>> python3 tools/net/ynl/pyynl/cli.py \
>>     --spec Documentation/netlink/specs/netdev.yaml \
>>     --do queue-get --json '{"ifindex": 3, "type": "rx", "id": 2}'
>> {'id': 2, 'ifindex': 3, 'napi-id': 515, 'type': 'rx'}
> 
> Hi Samiullah,
> 
> Thanks for the patch. We do, however, have this functionality already in
> flight [1].

Yes, and it requires handling RTNL locks differently in several reset
and reconfig paths. Just adding netif_napi_set_*() won't work properly.

> 
> Thanks,
> Tony
> 
> [1] https://lore.kernel.org/intel-wired-lan/20250624164515.2663137-4-
> aleksander.lobakin@...el.com/

Thanks,
Olek