netdev - Re: [EXTERNAL]Re: [PATCH net-next v5 2/2] net: pse-pd: Add Si3474 PSE controller driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <01bce50b-77e1-4ee5-8a02-9db7a2845c8f@adtran.com>
Date: Fri, 18 Jul 2025 18:09:20 +0000
From: Piotr Kubik <piotr.kubik@...ran.com>
To: Kory Maincent <kory.maincent@...tlin.com>
CC: Oleksij Rempel <o.rempel@...gutronix.de>, Andrew Lunn
	<andrew+netdev@...n.ch>, "David S. Miller" <davem@...emloft.net>, Eric
 Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
	<pabeni@...hat.com>, Rob Herring <robh@...nel.org>, Krzysztof Kozlowski
	<krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [EXTERNAL]Re: [PATCH net-next v5 2/2] net: pse-pd: Add Si3474 PSE
 controller driver

On 7/18/25 19:26, Kory Maincent wrote:
> Le Fri, 11 Jul 2025 11:25:02 +0000,
> Piotr Kubik <piotr.kubik@...ran.com> a écrit :
...
> 
>> +static int si3474_pi_get_admin_state(struct pse_controller_dev *pcdev, int
>> id,
>> +				     struct pse_admin_state *admin_state)
>> +{
>> +	struct si3474_priv *priv = to_si3474_priv(pcdev);
>> +	struct i2c_client *client;
>> +	s32 ret;
>> +	u8 chan0, chan1;
>> +	bool is_enabled = false;
> 
> I think you forgot to fix the xmas style here. 
...>> +
>> +static int si3474_pi_disable(struct pse_controller_dev *pcdev, int id)
>> +{
>> +	struct si3474_priv *priv = to_si3474_priv(pcdev);
>> +	struct i2c_client *client;
>> +	s32 ret;
>> +	u8 chan0, chan1;
>> +	u8 val = 0;
> 
> And here, and other places in the patch. Are you sure you did it as you
> described in your cover letter?
> The code seems ok otherwise.

Well, my bad. I read too quickly and understood netdev rev xmas style description:
"Order the variable declaration lines longest to shortest"
as order the variable declaration by their size, longest to shortest (which I even considered reasonable)

Will fix 

Thanks 
/Piotr