netdev - Re: [PATCH] net: mctp: Add MCTP PCIe VDM transport driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <05aa941118f1dee000a05a9eeccb7a33e3e14d23.camel@codeconstruct.com.au>
Date: Fri, 18 Jul 2025 11:24:55 +0800
From: Jeremy Kerr <jk@...econstruct.com.au>
To: YH Chung <yh_chung@...eedtech.com>, "matt@...econstruct.com.au"
 <matt@...econstruct.com.au>, "andrew+netdev@...n.ch"
 <andrew+netdev@...n.ch>,  "davem@...emloft.net" <davem@...emloft.net>,
 "edumazet@...gle.com" <edumazet@...gle.com>,  "kuba@...nel.org"
 <kuba@...nel.org>, "pabeni@...hat.com" <pabeni@...hat.com>, 
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "netdev@...r.kernel.org" <netdev@...r.kernel.org>, BMC-SW
 <BMC-SW@...eedtech.com>
Cc: Khang D Nguyen <khangng@...eremail.onmicrosoft.com>
Subject: Re: [PATCH] net: mctp: Add MCTP PCIe VDM transport driver

Hi YH,

> We're planning to split the MCTP controller driver into two separate
> drivers for AST2600 and AST2700, removing the AST2600-specific
> workarounds in the process for improving long-term maintainability.
> And it's part of the reason we want to decouple the binding protocol
> logic into its own layer.

The split is entirely up to you (and sounds reasonable), but the
"binding protocol logic" is really minimal. I would think a couple of
shared helper functions should be sufficient?

> Would it be preferable to create a directory such as net/mctp/aspeed/
> to host the abstraction layer alongside the hardware-specific
> drivers?

Just put them in the top-level at drivers/net/mctp/ for now. There's not
much in there at present, so will be simple to keep organised. If you
end up with two drivers and a common set of utils between the two,
that's a total of four files, which I think we can manage.

Cheers,


Jeremy