netdev - Re: [PATCH net-next v4 1/7] dt-bindings: net: airoha: npu: Add memory regions used for wlan offload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aHoWY6iGN-lJnu60@lore-desk>
Date: Fri, 18 Jul 2025 11:39:47 +0200
From: Lorenzo Bianconi <lorenzo@...nel.org>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, Simon Horman <horms@...nel.org>,
	linux-arm-kernel@...ts.infradead.org,
	linux-mediatek@...ts.infradead.org, netdev@...r.kernel.org,
	devicetree@...r.kernel.org
Subject: Re: [PATCH net-next v4 1/7] dt-bindings: net: airoha: npu: Add
 memory regions used for wlan offload

> On Thu, Jul 17, 2025 at 08:57:42AM +0200, Lorenzo Bianconi wrote:
> > Document memory regions used by Airoha EN7581 NPU for wlan traffic
> > offloading. The brand new added memory regions do not introduce any
> > backward compatibility issues since they will be used just to offload
> > traffic to/from the MT76 wireless NIC and the MT76 probing will not fail
> > if these memory regions are not provide, it will just disable offloading
> > via the NPU module.
> 
> That's not what I see entirely. I see the same problem I told you already.
> of_reserved_mem_region_to_resource_byname returns error ->
> airoha_npu_wlan_init_memory returns error -> your other patchset prints
> big fat warning in mt7996_pci_probe().

Is it ok to use dev_info() instead dev_warn() or do you prefer to completely
remove the log?

> 
> So all correct DTS now gets a warning. Warning is a state of failure,
> even if probe proceeds.
> 
> I don't understand why you can't make it fully optional, so also fully
> backwards compatible.

I am completely fine to make it fully optional, but can you please explain
what you mean here with 'optional'?

At the moment in mt76_npu_init() we first look for the "airoha,npu" property
in mt76 node to load the NPU pointer running airoha_npu_get():

wifi@0,0 {
	compatible = "mediatek,mt76";
	...
	airoha,npu = <&npu>;
	...
};

If this property is defined in the wifi node I guess it is fine to assume
even the NPU memory regions are properly defined int the DTS.

Is it ok to use dev_info() instead of dev_warn() in mt7996_pci_probe() if
the mt76_npu_init() returns an error (e.g. if the "airoha,npu" is not defined)
or do you prefer to do something else to make this process optional?

Regards,
Lorenzo

> 
> Best regards,
> Krzysztof
> 

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)