netdev - Re: [PATCH] net: phy: Fix premature resume by a PHY driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202507191322.YG6cNwF6-lkp@intel.com>
Date: Sat, 19 Jul 2025 13:37:05 +0800
From: kernel test robot <lkp@...el.com>
To: Abid Ali <dev.nuvorolabs@...il.com>, Andrew Lunn <andrew@...n.ch>,
	Heiner Kallweit <hkallweit1@...il.com>,
	Russell King <linux@...linux.org.uk>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	Abid Ali <dev.nuvorolabs@...il.com>
Subject: Re: [PATCH] net: phy: Fix premature resume by a PHY driver

Hi Abid,

kernel test robot noticed the following build warnings:

[auto build test WARNING on 347e9f5043c89695b01e66b3ed111755afcf1911]

url:    https://github.com/intel-lab-lkp/linux/commits/Abid-Ali/net-phy-Fix-premature-resume-by-a-PHY-driver/20250718-234858
base:   347e9f5043c89695b01e66b3ed111755afcf1911
patch link:    https://lore.kernel.org/r/20250718-phy_resume-v1-1-9c6b59580bee%40gmail.com
patch subject: [PATCH] net: phy: Fix premature resume by a PHY driver
config: i386-buildonly-randconfig-004-20250719 (https://download.01.org/0day-ci/archive/20250719/202507191322.YG6cNwF6-lkp@intel.com/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250719/202507191322.YG6cNwF6-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202507191322.YG6cNwF6-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/net/phy/phy_device.c:1849:33: warning: '&&' within '||' [-Wlogical-op-parentheses]
    1849 |         if (!phydrv || !phydrv->resume && phydev->suspended)
         |                     ~~ ~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~
   drivers/net/phy/phy_device.c:1849:33: note: place parentheses around the '&&' expression to silence this warning
    1849 |         if (!phydrv || !phydrv->resume && phydev->suspended)
         |                                        ^                   
         |                        (                                   )
   1 warning generated.


vim +1849 drivers/net/phy/phy_device.c

  1841	
  1842	int __phy_resume(struct phy_device *phydev)
  1843	{
  1844		const struct phy_driver *phydrv = phydev->drv;
  1845		int ret;
  1846	
  1847		lockdep_assert_held(&phydev->lock);
  1848	
> 1849		if (!phydrv || !phydrv->resume && phydev->suspended)
  1850			return 0;
  1851	
  1852		ret = phydrv->resume(phydev);
  1853		if (!ret)
  1854			phydev->suspended = false;
  1855	
  1856		return ret;
  1857	}
  1858	EXPORT_SYMBOL(__phy_resume);
  1859	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki