netdev - Re: [PATCH net] net: stmmac: intel: populate entire system_counterval_t in get_time

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87o6tguf25.ffs@tglx>
Date: Sat, 19 Jul 2025 22:00:02 +0200
From: Thomas Gleixner <tglx@...utronix.de>
To: Markus Blöchl <markus@...chl.de>, Andrew Lunn
 <andrew+netdev@...n.ch>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet
 <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
 <pabeni@...hat.com>, Maxime Coquelin <mcoquelin.stm32@...il.com>,
 Alexandre Torgue <alexandre.torgue@...s.st.com>
Cc: Lakshmi Sowjanya D <lakshmi.sowjanya.d@...el.com>, Richard Cochran
 <richardcochran@...il.com>, John Stultz <jstultz@...gle.com>,
 netdev@...r.kernel.org, linux-stm32@...md-mailman.stormreply.com,
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
 markus.bloechl@...tronik.com, Markus Blöchl
 <markus@...chl.de>
Subject: Re: [PATCH net] net: stmmac: intel: populate entire
 system_counterval_t in get_time_fn() callback

On Sun, Jul 13 2025 at 22:21, Markus Blöchl wrote:
> get_time_fn() callback implementations are expected to fill out the
> entire system_counterval_t struct as it may be initially uninitialized.
>
> This broke with the removal of convert_art_to_tsc() helper functions
> which left use_nsecs uninitialized.

Sigh. As I explained in the other thread, the proper fix is to
zero initialize the data structure at the call site and fix this whole
class of issues in one go.