| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <20250719220341.1615951-7-xiyou.wangcong@gmail.com>
Date: Sat, 19 Jul 2025 15:03:41 -0700
From: Cong Wang <xiyou.wangcong@...il.com>
To: netdev@...r.kernel.org
Cc: jhs@...atatu.com,
will@...lsroot.io,
stephen@...workplumber.org,
Cong Wang <xiyou.wangcong@...il.com>
Subject: [Patch v4 net 6/6] selftests/tc-testing: Update test cases with netem duplicate
Now netem does no longer trigger reentrant behaviour of its upper
qdiscs, the whole architecture becomes more solid and less error prone.
Keep these test cases since one of them still sucessfully caught a bug
in QFQ qdisc, but update them to the new netem enqueue behavior.
Signed-off-by: Cong Wang <xiyou.wangcong@...il.com>
---
.../tc-testing/tc-tests/infra/qdiscs.json | 54 +++++++++----------
1 file changed, 25 insertions(+), 29 deletions(-)
diff --git a/tools/testing/selftests/tc-testing/tc-tests/infra/qdiscs.json b/tools/testing/selftests/tc-testing/tc-tests/infra/qdiscs.json
index b4a507bc48a3..d43cd3c17526 100644
--- a/tools/testing/selftests/tc-testing/tc-tests/infra/qdiscs.json
+++ b/tools/testing/selftests/tc-testing/tc-tests/infra/qdiscs.json
@@ -381,7 +381,7 @@
},
{
"id": "90ec",
- "name": "Test DRR's enqueue reentrant behaviour with netem",
+ "name": "Test DRR with NETEM duplication",
"category": [
"qdisc",
"drr"
@@ -399,11 +399,11 @@
],
"cmdUnderTest": "ping -c 1 -I $DUMMY 10.10.10.1 > /dev/null || true",
"expExitCode": "0",
- "verifyCmd": "$TC -j -s qdisc ls dev $DUMMY handle 1:0",
+ "verifyCmd": "$TC -j -s qdisc ls dev $DUMMY handle 2:0",
"matchJSON": [
{
- "kind": "drr",
- "handle": "1:",
+ "kind": "netem",
+ "handle": "2:",
"bytes": 196,
"packets": 2
}
@@ -416,7 +416,7 @@
},
{
"id": "1f1f",
- "name": "Test ETS's enqueue reentrant behaviour with netem",
+ "name": "Test ETS with NETEM duplication",
"category": [
"qdisc",
"ets"
@@ -434,15 +434,13 @@
],
"cmdUnderTest": "ping -c 1 -I $DUMMY 10.10.10.1 > /dev/null || true",
"expExitCode": "0",
- "verifyCmd": "$TC -j -s class show dev $DUMMY",
+ "verifyCmd": "$TC -j -s qdisc show dev $DUMMY handle 2:0",
"matchJSON": [
{
- "class": "ets",
- "handle": "1:1",
- "stats": {
- "bytes": 196,
- "packets": 2
- }
+ "kind": "netem",
+ "handle": "2:",
+ "bytes": 196,
+ "packets": 2
}
],
"matchCount": "1",
@@ -453,7 +451,7 @@
},
{
"id": "5e6d",
- "name": "Test QFQ's enqueue reentrant behaviour with netem",
+ "name": "Test QFQ with NETEM duplication",
"category": [
"qdisc",
"qfq"
@@ -471,11 +469,11 @@
],
"cmdUnderTest": "ping -c 1 -I $DUMMY 10.10.10.1 > /dev/null || true",
"expExitCode": "0",
- "verifyCmd": "$TC -j -s qdisc ls dev $DUMMY handle 1:0",
+ "verifyCmd": "$TC -j -s qdisc ls dev $DUMMY handle 2:0",
"matchJSON": [
{
- "kind": "qfq",
- "handle": "1:",
+ "kind": "netem",
+ "handle": "2:",
"bytes": 196,
"packets": 2
}
@@ -488,7 +486,7 @@
},
{
"id": "bf1d",
- "name": "Test HFSC's enqueue reentrant behaviour with netem",
+ "name": "Test HFSC with NETEM duplication",
"category": [
"qdisc",
"hfsc"
@@ -512,13 +510,11 @@
],
"cmdUnderTest": "ping -c 1 10.10.10.2 -I$DUMMY > /dev/null || true",
"expExitCode": "0",
- "verifyCmd": "$TC -j -s qdisc ls dev $DUMMY handle 1:0",
+ "verifyCmd": "$TC -j -s qdisc ls dev $DUMMY handle 3:0",
"matchJSON": [
{
- "kind": "hfsc",
- "handle": "1:",
- "bytes": 392,
- "packets": 4
+ "kind": "netem",
+ "handle": "3:"
}
],
"matchCount": "1",
@@ -529,7 +525,7 @@
},
{
"id": "7c3b",
- "name": "Test nested DRR's enqueue reentrant behaviour with netem",
+ "name": "Test nested DRR with NETEM duplication",
"category": [
"qdisc",
"drr"
@@ -550,13 +546,13 @@
],
"cmdUnderTest": "ping -c 1 -I $DUMMY 10.10.10.1 > /dev/null || true",
"expExitCode": "0",
- "verifyCmd": "$TC -j -s qdisc ls dev $DUMMY handle 1:0",
+ "verifyCmd": "$TC -j -s qdisc ls dev $DUMMY handle 3:0",
"matchJSON": [
{
- "kind": "drr",
- "handle": "1:",
- "bytes": 196,
- "packets": 2
+ "kind": "netem",
+ "handle": "3:",
+ "bytes": 98,
+ "packets": 1
}
],
"matchCount": "1",
@@ -629,7 +625,7 @@
},
{
"id": "309e",
- "name": "Test HFSC eltree double add with reentrant enqueue behaviour on netem",
+ "name": "Test complex HFSC with NETEM duplication",
"category": [
"qdisc",
"hfsc"
--
2.34.1
Powered by blists - more mailing lists