netdev - Re: [PATCH net-next 4/8] ethtool: rss: factor out populating response from context

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f90b8a8b-cf03-41e4-8022-3df3f8542f2e@nvidia.com>
Date: Sun, 20 Jul 2025 14:12:47 +0300
From: Gal Pressman <gal@...dia.com>
To: Jakub Kicinski <kuba@...nel.org>, davem@...emloft.net
Cc: netdev@...r.kernel.org, edumazet@...gle.com, pabeni@...hat.com,
 andrew+netdev@...n.ch, horms@...nel.org, andrew@...n.ch,
 donald.hunter@...il.com, shuah@...nel.org, kory.maincent@...tlin.com,
 ecree.xilinx@...il.com
Subject: Re: [PATCH net-next 4/8] ethtool: rss: factor out populating response
 from context

On 18/07/2025 2:43, Jakub Kicinski wrote:
> Similarly to previous change, factor out populating the response.
> We will use this after the context was allocated to send a notification
> so this time factor out from the additional context handling, rather
> than context 0 handling (for request context didn't exist, for response
> it does).
> 
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Reviewed-by: Gal Pressman <gal@...dia.com>

> ---
>  net/ethtool/rss.c | 32 ++++++++++++++++++++++----------
>  1 file changed, 22 insertions(+), 10 deletions(-)
> 
> diff --git a/net/ethtool/rss.c b/net/ethtool/rss.c
> index 07a9d89e1c6b..e5516e529b4a 100644
> --- a/net/ethtool/rss.c
> +++ b/net/ethtool/rss.c
> @@ -179,6 +179,25 @@ rss_prepare_get(const struct rss_req_info *request, struct net_device *dev,
>  	return ret;
>  }
>  
> +static void
> +__rss_prepare_ctx(struct net_device *dev, struct rss_reply_data *data,
> +		  struct ethtool_rxfh_context *ctx)
> +{
> +	if (WARN_ON_ONCE(data->indir_size != ctx->indir_size ||
> +			 data->hkey_size != ctx->key_size))

I Wouldn't consider this part of "factoring out".