netdev - Re: [PATCH net-next v4 2/4] net: vxlan: add netlink option to bind vxlan sockets to local addresses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aHz4vvDSbi8GhbhU@shredder>
Date: Sun, 20 Jul 2025 17:10:06 +0300
From: Ido Schimmel <idosch@...dia.com>
To: Richard Gobert <richardbgobert@...il.com>
Cc: davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, horms@...nel.org, dsahern@...nel.org,
	razor@...ckwall.org, petrm@...dia.com, menglong8.dong@...il.com,
	daniel@...earbox.net, martin.lau@...nel.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v4 2/4] net: vxlan: add netlink option to bind
 vxlan sockets to local addresses

On Thu, Jul 17, 2025 at 01:54:10PM +0200, Richard Gobert wrote:
> diff --git a/drivers/net/vxlan/vxlan_core.c b/drivers/net/vxlan/vxlan_core.c
> index bcde95cb2a2e..667ff17c4569 100644
> --- a/drivers/net/vxlan/vxlan_core.c
> +++ b/drivers/net/vxlan/vxlan_core.c
> @@ -3406,6 +3406,7 @@ static const struct nla_policy vxlan_policy[IFLA_VXLAN_MAX + 1] = {
>  	[IFLA_VXLAN_LABEL_POLICY]       = NLA_POLICY_MAX(NLA_U32, VXLAN_LABEL_MAX),
>  	[IFLA_VXLAN_RESERVED_BITS] = NLA_POLICY_EXACT_LEN(sizeof(struct vxlanhdr)),
>  	[IFLA_VXLAN_MC_ROUTE]		= NLA_POLICY_MAX(NLA_U8, 1),
> +	[IFLA_VXLAN_LOCALBIND]	= { .type = NLA_U8 },

NLA_POLICY_MAX(NLA_U8, 1) is more future proof in the unlikely case that
we would want to assign different meanings to values greater than 1.

>  };