netdev - Re: [PATCH iproute2-next] misc: ss.c: fix logical error in main function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250720081537.0c18194c@hermes.local>
Date: Sun, 20 Jul 2025 08:15:37 -0700
From: Stephen Hemminger <stephen@...workplumber.org>
To: Anton Moryakov <ant.v.moryakov@...il.com>
Cc: netdev@...r.kernel.org
Subject: Re: [PATCH iproute2-next] misc: ss.c: fix logical error in main
 function

On Sat, 19 Jul 2025 19:31:22 +0300
Anton Moryakov <ant.v.moryakov@...il.com> wrote:

> In the line if (!dump_tcpdiag) { there was a logical error 
> in checking the descriptor, which the static analyzer complained 
> about (this action is always false)
> 
> fixed by replacing !dump_tcpdiag with !dump_fp
> 
> Reported-by: SVACE static analyzer
> Signed-off-by: Anton Moryakov <ant.v.moryakov@...il.com>

Acked-by: Stephen Hemminger <stephen@...workplumber.org>