netdev - Re: [PATCH net-next 2/8] net: dsa: b53: mmap: Add reference to bcm63xx gpio controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250720223754.GA2930944-robh@kernel.org>
Date: Sun, 20 Jul 2025 17:37:54 -0500
From: Rob Herring <robh@...nel.org>
To: Kyle Hendry <kylehendrydev@...il.com>
Cc: Florian Fainelli <florian.fainelli@...adcom.com>,
	Andrew Lunn <andrew@...n.ch>, Vladimir Oltean <olteanv@...il.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Russell King <linux@...linux.org.uk>, noltari@...il.com,
	jonas.gorski@...il.com, Florian Fainelli <f.fainelli@...il.com>,
	netdev@...r.kernel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next 2/8] net: dsa: b53: mmap: Add reference to
 bcm63xx gpio controller

On Tue, Jul 15, 2025 at 05:29:01PM -0700, Kyle Hendry wrote:
> On bcm63xx SoCs there are registers that control the PHYs in
> the GPIO controller. Allow the b53 driver to access them
> by passing in the syscon through the device tree.

Bindings go before users of the binding.

More importantly, this patch does nothing on its own. Squash it with 
were you actually use priv->gpio_ctrl.

> 
> Signed-off-by: Kyle Hendry <kylehendrydev@...il.com>
> ---
>  drivers/net/dsa/b53/b53_mmap.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/net/dsa/b53/b53_mmap.c b/drivers/net/dsa/b53/b53_mmap.c
> index c687360a5b7f..a0c06d703861 100644
> --- a/drivers/net/dsa/b53/b53_mmap.c
> +++ b/drivers/net/dsa/b53/b53_mmap.c
> @@ -21,6 +21,7 @@
>  #include <linux/module.h>
>  #include <linux/of.h>
>  #include <linux/io.h>
> +#include <linux/mfd/syscon.h>
>  #include <linux/platform_device.h>
>  #include <linux/platform_data/b53.h>
>  
> @@ -28,6 +29,7 @@
>  
>  struct b53_mmap_priv {
>  	void __iomem *regs;
> +	struct regmap *gpio_ctrl;
>  };
>  
>  static int b53_mmap_read8(struct b53_device *dev, u8 page, u8 reg, u8 *val)
> @@ -313,6 +315,8 @@ static int b53_mmap_probe(struct platform_device *pdev)
>  
>  	priv->regs = pdata->regs;
>  
> +	priv->gpio_ctrl = syscon_regmap_lookup_by_phandle(np, "brcm,gpio-ctrl");
> +
>  	dev = b53_switch_alloc(&pdev->dev, &b53_mmap_ops, priv);
>  	if (!dev)
>  		return -ENOMEM;
> -- 
> 2.43.0
>