netdev - Re: [PATCH net-next 1/4] dt-bindings: net: document st,phy-wol property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b220ae01-81b5-47f1-bf99-9aa0903995e1@kernel.org>
Date: Mon, 21 Jul 2025 14:16:57 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Gatien CHEVALLIER <gatien.chevallier@...s.st.com>,
 Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>,
 Maxime Coquelin <mcoquelin.stm32@...il.com>,
 Alexandre Torgue <alexandre.torgue@...s.st.com>,
 Christophe Roullier <christophe.roullier@...s.st.com>,
 Andrew Lunn <andrew@...n.ch>, Heiner Kallweit <hkallweit1@...il.com>,
 Russell King <linux@...linux.org.uk>, Simon Horman <horms@...nel.org>,
 Tristram Ha <Tristram.Ha@...rochip.com>,
 Florian Fainelli <florian.fainelli@...adcom.com>
Cc: netdev@...r.kernel.org, devicetree@...r.kernel.org,
 linux-stm32@...md-mailman.stormreply.com,
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next 1/4] dt-bindings: net: document st,phy-wol
 property

On 21/07/2025 14:10, Gatien CHEVALLIER wrote:
> Hello Krzysztof,
> 
> On 7/21/25 13:30, Krzysztof Kozlowski wrote:
>> On 21/07/2025 13:14, Gatien Chevallier wrote:
>>> The "st,phy-wol" property can be set to use the wakeup capability of
>>> the PHY instead of the MAC.
>>
>>
>> And why would that be property of a SoC or board? Word "can" suggests
>> you are documenting something which exists, but this does not exist.
> Can you elaborate a bit more on the "not existing" part please?

Where does this property exist that you suggest that a new binding "can"
use it?

> 
> For the WoL from PHY to be supported, the PHY line that is raised
> (On nPME pin for this case) when receiving a wake up event has to be
> wired to a wakeup event input of the Extended interrupt and event
> controller(EXTI), and that's implementation dependent.

So it is not "can" but some implementations do not have proper wiring.
You need to justify your commits and changes.

Best regards,
Krzysztof