netdev - Re: [PATCH nf-next v4 1/2] net: netfilter: Add IPIP flowtable SW acceleration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aH5HNm1VKqP-g5rB@strlen.de>
Date: Mon, 21 Jul 2025 15:57:10 +0200
From: Florian Westphal <fw@...len.de>
To: Lorenzo Bianconi <lorenzo@...nel.org>
Cc: "David S. Miller" <davem@...emloft.net>,
	David Ahern <dsahern@...nel.org>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Simon Horman <horms@...nel.org>,
	Pablo Neira Ayuso <pablo@...filter.org>,
	Jozsef Kadlecsik <kadlec@...filter.org>,
	Shuah Khan <shuah@...nel.org>, Andrew Lunn <andrew+netdev@...n.ch>,
	netdev@...r.kernel.org, netfilter-devel@...r.kernel.org,
	coreteam@...filter.org, linux-kselftest@...r.kernel.org
Subject: Re: [PATCH nf-next v4 1/2] net: netfilter: Add IPIP flowtable SW
 acceleration

Lorenzo Bianconi <lorenzo@...nel.org> wrote:
> I guess the point is we run nf_flow_skb_encap_protocol() not only for IPIP
> traffic but even for plain IP traffic (e.g. IP+UDP) in nf_flow_offload_lookup().
> In particular, we run the following check in nf_flow_tuple_ip() for IP+UDP
> traffic:
> 
> pskb_may_pull(, 28)
> 
> That is less restrictive with respect to
> 
> pskb_may_pull(, 40)

Its in different functions?  40 bytes in linear area is a prerequisite
for IPIP, and a check failure will not drop the skb; we'll still
progress onwards to .  But ok, it will be caught later too, so lets keep
it as-is.