netdev - Re: [PATCH net-next 6/8] ethtool: rss: support creating contexts via Netlink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250721082111.6826d138@kernel.org>
Date: Mon, 21 Jul 2025 08:21:11 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Gal Pressman <gal@...dia.com>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
 pabeni@...hat.com, andrew+netdev@...n.ch, horms@...nel.org, andrew@...n.ch,
 donald.hunter@...il.com, shuah@...nel.org, kory.maincent@...tlin.com,
 ecree.xilinx@...il.com
Subject: Re: [PATCH net-next 6/8] ethtool: rss: support creating contexts
 via Netlink

On Sun, 20 Jul 2025 14:42:36 +0300 Gal Pressman wrote:
> On 18/07/2025 2:43, Jakub Kicinski wrote:
> > +Kernel response contents:
> > +
> > +=====================================  ======  ==============================
> > +  ``ETHTOOL_A_RSS_HEADER``             nested  request header
> > +  ``ETHTOOL_A_RSS_CONTEXT``            u32     context number
> > +=====================================  ======  ==============================
> > +
> > +Create an additional RSS context, if ``ETHTOOL_A_RSS_CONTEXT`` is not
> > +specified kernel will allocate one automatically.  
> 
> We don't support choosing the context id from userspace in ioctl flow, I
> think it should be stated somewhere (at the least, in the commit message?).

Sure, how about:

  Support letting user choose the ID for the new context. This was not
  possible in IOCTL since the context ID field for the create action had
  to be set to the ETH_RXFH_CONTEXT_ALLOC magic value.